You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/13 13:06:29 UTC
[GitHub] [airflow] ashb opened a new pull request #7411: [AIRFLOW-6344] Fix
travis CI for tag builds
ashb opened a new pull request #7411: [AIRFLOW-6344] Fix travis CI for tag builds
URL: https://github.com/apache/airflow/pull/7411
Don't try to find changed files unless we are building a pull request.
This only caused a problem on build of tags, but we were also doing this
for master/branch builds, but it was always saying finding no files
changed.
By checking this early we can make the other conditions in this function
simpler.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7411: [AIRFLOW-6344] Fix
travis CI for tag builds
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7411: [AIRFLOW-6344] Fix travis CI for tag builds
URL: https://github.com/apache/airflow/pull/7411#issuecomment-585746456
Thanks! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7411: [AIRFLOW-6344] Fix
travis CI for tag builds
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7411: [AIRFLOW-6344] Fix travis CI for tag builds
URL: https://github.com/apache/airflow/pull/7411#issuecomment-585764445
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=h1) Report
> Merging [#7411](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6b19889c0151b66202c2b1b38d99cbb54529b255?src=pr&el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7411 +/- ##
==========================================
+ Coverage 86.44% 86.63% +0.18%
==========================================
Files 874 874
Lines 40868 40868
==========================================
+ Hits 35330 35405 +75
+ Misses 5538 5463 -75
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/api/experimental/endpoints.py](https://codecov.io/gh/apache/airflow/pull/7411/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBpL2V4cGVyaW1lbnRhbC9lbmRwb2ludHMucHk=) | `89.81% <0%> (ø)` | :arrow_up: |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/7411/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.85% <0%> (+0.13%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7411/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88.12% <0%> (+0.19%)` | :arrow_up: |
| [...roviders/amazon/aws/operators/s3\_delete\_objects.py](https://codecov.io/gh/apache/airflow/pull/7411/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvczNfZGVsZXRlX29iamVjdHMucHk=) | `100% <0%> (+9.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=footer). Last update [6b19889...b6fa41d](https://codecov.io/gh/apache/airflow/pull/7411?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb merged pull request #7411: [AIRFLOW-6344] Fix travis
CI for tag builds
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #7411: [AIRFLOW-6344] Fix travis CI for tag builds
URL: https://github.com/apache/airflow/pull/7411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7411: [AIRFLOW-6344] Fix travis
CI for tag builds
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7411: [AIRFLOW-6344] Fix travis CI for tag builds
URL: https://github.com/apache/airflow/pull/7411#issuecomment-585745513
I've tested this with tag build on our fork and it no longer errors the build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services