[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4722: [Improve][Zeta] Remove serialize(deserialize) cost when use shuffle action

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #4722:
URL: https://github.com/apache/incubator-seatunnel/pull/4722#discussion_r1190655613


##########
seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/checkpoint/CheckpointType.java:
##########
@@ -31,6 +31,15 @@ public enum CheckpointType {
     private final boolean auto;
     private final String name;
 
+    public static CheckpointType fromName(String name) {
+        for (CheckpointType type : CheckpointType.values()) {
+            if (type.name.equals(name)) {
+                return type;
+            }
+        }
+        throw new IllegalArgumentException("Unknown checkpoint type: " + name);

Review Comment:
   There just value convert to enum. I think we don't need `CheckpointException`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org