You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/02/14 17:19:11 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #34156: GH-34150: [C++] [Python] Fix improper initialization of ConversionOptions

rtpsw commented on code in PR #34156:
URL: https://github.com/apache/arrow/pull/34156#discussion_r1106125463


##########
python/pyarrow/includes/libarrow_substrait.pxd:
##########
@@ -34,10 +50,26 @@ cdef extern from "arrow/engine/substrait/options.h" namespace "arrow::engine" no
         BEST_EFFORT \
             "arrow::engine::ConversionStrictness::BEST_EFFORT"
 
+    cdef cppclass CExtensionDetails \
+            "arrow::ending::ExtensionDetails"

Review Comment:
   It doesn't error in CI either. Surprising.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org