You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2017/03/07 17:38:12 UTC
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Joe McDonnell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6288
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
IMPALA-5038: Fix file size regex to include bytes
There is a regex to remove file sizes from test logs to avoid diffs caused
by changes in file headers, etc. The regex was detecting size=number correctly,
but it does not include the byte unit (i.e. size=900B is distinct from size=900KB).
A file size change introduced by IMPALA-4624 caused a diff because the file
size changed from 900B to 1.1KB. This fixes the regex to include the byte unit,
so that changes of this form do not cause diffs.
Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
---
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/6288/1
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
Patch Set 1:
(3 comments)
could you also fix up the contaminated tests as part of this?
http://gerrit.cloudera.org:8080/#/c/6288/1//COMMIT_MSG
Commit Message:
Line 9: There is a regex to remove file sizes from test logs to avoid diffs caused
long lines
http://gerrit.cloudera.org:8080/#/c/6288/1/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
File fe/src/test/java/org/apache/impala/testutil/TestUtils.java:
Line 88: // File size could vary from run to run. For example, parquet file header size could
please also fix the grammar of this comment
Line 99: return input.replaceAll(FILTER_KEY + NUMBER_FILTER + BYTE_FILTER, FILTER_KEY);
is this a case-sensitive match?
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6288/1//COMMIT_MSG
Commit Message:
Line 9: There is a regex to remove file sizes from test logs to avoid diffs caused
> long lines
Done
http://gerrit.cloudera.org:8080/#/c/6288/1/fe/src/test/java/org/apache/impala/testutil/TestUtils.java
File fe/src/test/java/org/apache/impala/testutil/TestUtils.java:
Line 88: // File size could vary from run to run. For example, parquet file header size could
> please also fix the grammar of this comment
Done
Line 99: return input.replaceAll(FILTER_KEY + NUMBER_FILTER + BYTE_FILTER, FILTER_KEY);
> is this a case-sensitive match?
Yes, this is case-sensitive.
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6288
to look at the new patch set (#2).
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
IMPALA-5038: Fix file size regex to include bytes
There is a regex to remove file sizes from test logs to avoid diffs
caused by changes in file headers, etc. The regex was detecting
size=number correctly, but it does not include the byte unit (i.e.
size=900B is distinct from size=900KB). A file size change introduced
by IMPALA-4624 caused a diff because the file size changed from 900B
to 1.1KB. This fixes the regex to include the byte unit, so that
changes of this form do not cause diffs.
Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
---
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/6288/2
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
IMPALA-5038: Fix file size regex to include bytes
There is a regex to remove file sizes from test logs to avoid diffs
caused by changes in file headers, etc. The regex was detecting
size=number correctly, but it does not include the byte unit (i.e.
size=900B is distinct from size=900KB). A file size change introduced
by IMPALA-4624 caused a diff because the file size changed from 900B
to 1.1KB. This fixes the regex to include the byte unit, so that
changes of this form do not cause diffs.
Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Reviewed-on: http://gerrit.cloudera.org:8080/6288
Reviewed-by: Marcel Kornacker <ma...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/testutil/TestUtils.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Marcel Kornacker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-ASF-CR] IMPALA-5038: Fix file size regex to include bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5038: Fix file size regex to include bytes
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/350/
--
To view, visit http://gerrit.cloudera.org:8080/6288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No