You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/17 21:01:29 UTC
[GitHub] [maven-artifact-plugin] elharo opened a new pull request #8: tidy up dependencies
elharo opened a new pull request #8:
URL: https://github.com/apache/maven-artifact-plugin/pull/8
@hboutemy Looks like this doesn't link the resolver API directly after all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] elharo commented on a change in pull request #8: tidy up dependencies
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #8:
URL: https://github.com/apache/maven-artifact-plugin/pull/8#discussion_r559756328
##########
File path: pom.xml
##########
@@ -87,17 +87,21 @@
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <version>${mavenVersion}</version>
Review comment:
done
##########
File path: pom.xml
##########
@@ -87,17 +87,21 @@
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <version>${mavenVersion}</version>
+ </dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.maven.resolver</groupId>
- <artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
- <scope>provided</scope>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-api</artifactId>
+ <version>0.9.0.M2</version>
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy commented on a change in pull request #8: tidy up dependencies
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #8:
URL: https://github.com/apache/maven-artifact-plugin/pull/8#discussion_r559245624
##########
File path: pom.xml
##########
@@ -87,17 +87,21 @@
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <version>${mavenVersion}</version>
Review comment:
provided scope, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy commented on a change in pull request #8: tidy up dependencies
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #8:
URL: https://github.com/apache/maven-artifact-plugin/pull/8#discussion_r559245652
##########
File path: pom.xml
##########
@@ -87,17 +87,21 @@
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-model</artifactId>
+ <version>${mavenVersion}</version>
+ </dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.maven.resolver</groupId>
- <artifactId>maven-resolver-api</artifactId>
- <version>1.4.1</version>
- <scope>provided</scope>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-api</artifactId>
+ <version>0.9.0.M2</version>
Review comment:
provided scope also, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-artifact-plugin] hboutemy merged pull request #8: tidy up dependencies
Posted by GitBox <gi...@apache.org>.
hboutemy merged pull request #8:
URL: https://github.com/apache/maven-artifact-plugin/pull/8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org