You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/04/26 23:38:50 UTC
Review Request 58761: Added --secret-fetcher flag for agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58761/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Added --secret-fetcher flag for agent.
Diffs
-----
src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3
src/slave/flags.hpp 38c05af99631059958868311adcc55774fbc6015
src/slave/flags.cpp f22837c8c94463c2da1ddfde9ed954631a3f38bd
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
Diff: https://reviews.apache.org/r/58761/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 58761: Added --secret-fetcher flag for agent.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58761/#review173157
-----------------------------------------------------------
Bad patch!
Reviews applied: [58761, 58760, 58759, 58758]
Failed command: python support/apply-reviews.py -n -r 58758
Error:
2017-04-27 05:55:48 URL:https://reviews.apache.org/r/58758/diff/raw/ [926/926] -> "58758.patch" [1]
error: patch failed: include/mesos/mesos.proto:2109
error: include/mesos/mesos.proto: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17869/console
- Mesos Reviewbot
On April 26, 2017, 11:38 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58761/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 11:38 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added --secret-fetcher flag for agent.
>
>
> Diffs
> -----
>
> src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3
> src/slave/flags.hpp 38c05af99631059958868311adcc55774fbc6015
> src/slave/flags.cpp f22837c8c94463c2da1ddfde9ed954631a3f38bd
> src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
>
>
> Diff: https://reviews.apache.org/r/58761/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 58761: Added --secret-fetcher flag for agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58761/#review173517
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/main.cpp
Line 234 (original), 243-245 (patched)
<https://reviews.apache.org/r/58761/#comment246505>
why is this mentioned twice? what's the difference between "Secret fetcher" and "SecretFetcher" ?
- Vinod Kone
On April 28, 2017, 6:51 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58761/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 6:51 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-7418
> https://issues.apache.org/jira/browse/MESOS-7418
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The flag accepts a module name. The module should be specified via `--modules` or `--modules_dir` flag.
>
>
> Diffs
> -----
>
> src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3
> src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94
> src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173
> src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
> src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
> src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
>
>
> Diff: https://reviews.apache.org/r/58761/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 58761: Added --secret-fetcher flag for agent.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58761/
-----------------------------------------------------------
(Updated April 28, 2017, 2:51 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Bugs: MESOS-7418
https://issues.apache.org/jira/browse/MESOS-7418
Repository: mesos
Description (updated)
-------
The flag accepts a module name. The module should be specified via `--modules` or `--modules_dir` flag.
Diffs (updated)
-----
src/local/local.cpp e47980929db2da1f31cf899a0e1fc452070e11f3
src/slave/flags.hpp c7a4604ed994e15c1db6accfaded2e882f1aec94
src/slave/flags.cpp c50e43c0e0ba633f6b905b0d78668c0a0eebb173
src/slave/main.cpp 72b141cb66f9df5bcc7b3f8cfcc2b06fcbd17e52
src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
src/slave/slave.cpp 8b8078dbb656e9db2efa53cc4ec5bed2cc01d49a
Diff: https://reviews.apache.org/r/58761/diff/2/
Changes: https://reviews.apache.org/r/58761/diff/1-2/
Testing
-------
Thanks,
Kapil Arya