You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergio Pena <se...@cloudera.com> on 2016/03/10 20:45:11 UTC
Re: Review Request 42726: HIVE-12891: Hive fails when java.io.tmpdir
is set to a relative location
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42726/#review122975
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java (line 50)
<https://reviews.apache.org/r/42726/#comment185071>
I wonder why just no called makeAbsolute() here? It will make the code readable without adding more classes.
Also, we should add some test cases that validates getSubstitute() with a java.io.tmpdir with a relative path value, and also a test case that validates our issue scenario mentioned in the JIRA.
- Sergio Pena
On March 8, 2016, 6 p.m., Reuben Kuhnert wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42726/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 6 p.m.)
>
>
> Review request for hive, Aihua Xu, Sergio Pena, Szehon Ho, and Xuefu Zhang.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Create a tool for hooking into SystemVariable requests to validate/coerce values before sending them to the user.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java 5dd9f407c23316f0a52651446a6038b9b69c6f12
> common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java 9f59f11ca6459853b15ca80fa9751db934befc71
> common/src/java/org/apache/hadoop/hive/conf/valcoersion/JavaIOTmpdirVariableCoercion.java PRE-CREATION
> common/src/java/org/apache/hadoop/hive/conf/valcoersion/VariableCoercion.java PRE-CREATION
> common/src/java/org/apache/hadoop/hive/conf/valcoersion/VariableCoercionSet.java PRE-CREATION
> common/src/test/org/apache/hadoop/hive/conf/TestValueCoersions.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42726/diff/
>
>
> Testing
> -------
>
> Tested locally, includes unit-test, tested against jenkins.
>
>
> Thanks,
>
> Reuben Kuhnert
>
>