You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/27 19:06:21 UTC
[GitHub] [incubator-gobblin] yukuai518 opened a new pull request #2970: [GOBBLIN-1129] Add staging table cleanup logic for avro2orc pipeline.
yukuai518 opened a new pull request #2970:
URL: https://github.com/apache/incubator-gobblin/pull/2970
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1129
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
During the avro2orc conversion, many staging tables are created, they are not cleaned up due to the pipeline failure, and next execution doesn't take care of the clean up, which caused the staging table taking many spaces in hive metastore.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2970: [GOBBLIN-1129] Add staging table cleanup logic for avro2orc pipeline.
Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #2970:
URL: https://github.com/apache/incubator-gobblin/pull/2970#discussion_r420329747
##########
File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/source/HiveAvroToOrcSource.java
##########
@@ -34,6 +34,25 @@
*/
public class HiveAvroToOrcSource extends HiveSource {
private Optional<LineageInfo> lineageInfo;
+ public static final String CLEAN_STAGING_TABLES_IN_SEARCH = "cleanStagingTablesInSearch";
+ public static final String DEFAULT_CLEAN_STAGING_FROM_BEGINNING = "true";
Review comment:
How about making this name match the one above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org