[GitHub] [kylin] weibin0516 commented on a change in pull request #928: KYLIN-4104 Support multi jdbc pushdown runners to execute query/update

[GitBox <gi...@apache.org>]

weibin0516 commented on a change in pull request #928: KYLIN-4104 Support multi jdbc pushdown runners to execute query/update
URL: https://github.com/apache/kylin/pull/928#discussion_r361632840
 
 

 ##########
 File path: query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java
 ##########
 @@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.query.util;
+
+import com.google.common.collect.Lists;
+
+import org.apache.calcite.sql.parser.SqlParseException;
+
+import org.apache.commons.lang3.exception.ExceptionUtils;
+
+import org.apache.kylin.common.KylinConfig;
+import org.apache.kylin.common.util.ClassUtil;
+import org.apache.kylin.common.util.Pair;
+import org.apache.kylin.metadata.querymeta.SelectedColumnMeta;
+import org.apache.kylin.query.adhoc.PushDownRunnerJdbcImpl;
+import org.apache.kylin.source.adhocquery.IPushDownRunner;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.SQLException;
+import java.util.List;
+
+
+/**
+ * Execute a pushdown query using a single or multiple runners depending on the configuration.
+ */
+public class PushDownExecutor {
+    private final Logger logger = LoggerFactory.getLogger(PushDownExecutor.class);
+    private KylinConfig kylinConfig = KylinConfig.getInstanceFromEnv();
+
+    public PushDownExecutor() {
+
+    }
+
+    public Pair<List<List<String>>, List<SelectedColumnMeta>> pushDownQuery(String project,
+            String sql, String defaultSchema, SQLException sqlException, boolean isSelect,
+            boolean isPrepare) throws Exception {
+        List<String> ids = kylinConfig.getPushDownRunnerIds();
+        if (ids.isEmpty()) {
+            IPushDownRunner runner = (IPushDownRunner) ClassUtil.newInstance(
+                    kylinConfig.getPushDownRunnerClassName()
+            );
+            runner.init(kylinConfig);
+            return queryBySingleRunner(runner, project, sql, defaultSchema, sqlException,
+                    isSelect, isPrepare);
+        } else {
+            return queryByMultiJdbcRunners(ids, project, sql, defaultSchema, sqlException,
+                    isSelect, isPrepare);
+        }
+    }
+
+    private Pair<List<List<String>>, List<SelectedColumnMeta>> queryBySingleRunner(IPushDownRunner runner,
+            String project, String sql, String defaultSchema, SQLException sqlException,
+            boolean isSelect, boolean isPrepare) throws Exception {
+
+        logger.debug("Query Pushdown runner {}", runner);
+
+        // default schema in calcite does not apply to other engines.
+        // since this is a universql requirement, it's not implemented as a converter
+        if (defaultSchema != null && !defaultSchema.equals("DEFAULT")) {
+            String completed = sql;
+            try {
+                completed = PushDownUtil.schemaCompletion(sql, defaultSchema);
+            } catch (SqlParseException e) {
+                // fail to parse the pushdown sql, ignore
+                logger.debug("fail to do schema completion on the pushdown sql, ignore it.",
+                        e.getMessage());
+            }
+            if (!sql.equals(completed)) {
+                logger.info("the query is converted to {} after schema completion", completed);
+                sql = completed;
+            }
+        }
+
+        sql = runner.convertSql(kylinConfig, sql, project, defaultSchema, isPrepare);
+
+        List<List<String>> returnRows = Lists.newArrayList();
+        List<SelectedColumnMeta> returnColumnMeta = Lists.newArrayList();
+
+        if (isSelect) {
+            runner.executeQuery(sql, returnRows, returnColumnMeta);
+        }
+        if (!isSelect && !isPrepare && kylinConfig.isPushDownUpdateEnabled()) {
+            runner.executeUpdate(sql);
+        }
+        return Pair.newPair(returnRows, returnColumnMeta);
+    }
+
+    private Pair<List<List<String>>, List<SelectedColumnMeta>> queryByMultiJdbcRunners(
+            List<String> ids, String project, String sql, String defaultSchema,
+            SQLException sqlException, boolean isSelect, boolean isPrepare) throws Exception {
+        Pair<List<List<String>>, List<SelectedColumnMeta>> ret = null;
+
+        for (int i = 0; i < ids.size(); i++) {
+            String id = ids.get(i);
+            PushDownRunnerJdbcImpl runner = new PushDownRunnerJdbcImpl();
+            runner.initById(kylinConfig, id);
+
+            try {
+                ret = queryBySingleRunner(runner, project, sql, defaultSchema, sqlException,
 
 Review comment:
   @nichunen , thanks to review, it has been fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services