[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1045: chore(build): remove the auto-generated Java code by thrift compiler

[GitBox <gi...@apache.org>]

foreverneverer commented on code in PR #1045:
URL: https://github.com/apache/incubator-pegasus/pull/1045#discussion_r926290659


##########
java-client/src/main/java/org/apache/pegasus/apps/batch_get_request.java:
##########
@@ -1,469 +0,0 @@
-/*

Review Comment:
   These auto-generated file should add into `.gitignore`, other same



##########
docker/pegasus-build-env/centos6/Dockerfile:
##########
@@ -20,16 +20,16 @@ FROM centos:6.10
 LABEL maintainer=jiashuo
 
 # defaut repo url hasn't been supported, use thirdparty repo url
-RUN curl https://www.getpagespeed.com/files/centos6-eol.repo --output /etc/yum.repos.d/CentOS-Base.repo
-RUN curl https://www.getpagespeed.com/files/centos6-epel-eol.repo --output /etc/yum.repos.d/epel.repo
-RUN curl https://www.getpagespeed.com/files/centos6-scl-eol.repo --output /etc/yum.repos.d/CentOS-SCLo-scl.repo
-RUN curl https://www.getpagespeed.com/files/centos6-scl-rh-eol.repo --output /etc/yum.repos.d/CentOS-SCLo-scl-rh.repo
+RUN wget --progress=dot:giga https://www.getpagespeed.com/files/centos6-eol.repo -O /etc/yum.repos.d/CentOS-Base.repo

Review Comment:
   it seems not have `wget` tools for the new centos env



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org