You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by dsclose <gi...@git.apache.org> on 2015/11/17 16:52:43 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
GitHub user dsclose opened a pull request:
https://github.com/apache/cloudstack/pull/1079
CLOUDSTACK-9058 - Respond with "saved_password" if no password is to be issued.
The password server on the virtual router should respond with "saved_password" if no password is to be issued. This allows for backwards compatibility with Windows Guest VMs which require the "saved_password" response.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dsclose/cloudstack CLOUDSTACK-9058
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1079.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1079
----
commit 8a7deefe64cab0b3c49ebc510c6524b1fad1f884
Author: dsclose <ds...@users.noreply.github.com>
Date: 2015-11-12T08:05:57Z
CLOUDSTACK-9058
Respond with "saved_password" if no password is to be issued.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157411634
This is a duplicate of PR https://github.com/apache/cloudstack/pull/1062
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157619773
Okay, understood.
I just read the other PR and saw your details about the tests, how you did it, ando also saw that @remibergsma already tested the existing features: which are working fine.
So, given the tests description + the LGTM from @remibergsma based on the marvin tests results, I LGTM this PR.
@dsclose: do you have any experience writing marvin tests? We can help you out. We need a test to cover what you described.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157670606
Gave LGTM on #1062, extending it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157416121
Should it be closed then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157416663
@wilderrodrigues no, i was asked to open this pull request by @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by dsclose <gi...@git.apache.org>.
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157672288
@wilderrodrigues I'd be pleased to write a Marvin test though I've not worked with them before. I think the first step would be to get the tests running on my local system. Do you have any docs for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9058 - Respond with "saved_pas...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1079#issuecomment-157421231
@wilderrodrigues I want to merge this to 4.6, so the one against master should be closed. As we merge forward now, we need bug fixes against 4.6. Otherwise it will not make it to 4.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---