You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shiro.apache.org by "Kalle Korhonen (JIRA)" <ji...@apache.org> on 2011/01/12 08:23:48 UTC

[jira] Created: (SHIRO-233) Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface

Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface
--------------------------------------------------------------------------------------------------------

                 Key: SHIRO-233
                 URL: https://issues.apache.org/jira/browse/SHIRO-233
             Project: Shiro
          Issue Type: Improvement
          Components: Specification API
    Affects Versions: 1.1.0, 1.0.0, 0.9
            Reporter: Kalle Korhonen
            Assignee: Kalle Korhonen
             Fix For: 1.2.0


Funny as it is, though we have AuthenticationListener interface, we don't have a way of adding or removing these listeners in the API (you can access AbstractAuthenticator's listener collection if your Authenticator extends it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Created: (SHIRO-233) Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface

Posted by Les Hazlewood <lh...@apache.org>.

Upon looking at this further, I don't feel that the Authenticator
interface should be changed - supporting listeners is an additional
feature IMO.  That is, just because an Authenticator exists, it
doesn't necessarily mean that listeners can be supported (depending on
the environment).

I believe we instead need to make an AuthenticationListenerRegistrar
interface and that should have the add/remove methods and the default
Authenticator implementation(s) should implement the
AuthenticationListenerRegistrar interface.  This achieves the same
result and is a little 'cleaner' IMO.

Any objections?

Les

On Tue, Jan 11, 2011 at 11:23 PM, Kalle Korhonen (JIRA) <ji...@apache.org> wrote:
> Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-233
>                 URL: https://issues.apache.org/jira/browse/SHIRO-233

[jira] [Updated] (SHIRO-233) Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it

Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHIRO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kalle Korhonen updated SHIRO-233:
---------------------------------

    Fix Version/s:     (was: 1.2.0)
                   1.3.0

> Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-233
>                 URL: https://issues.apache.org/jira/browse/SHIRO-233
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Specification API
>    Affects Versions: 0.9, 1.0.0, 1.1.0
>            Reporter: Kalle Korhonen
>            Assignee: Kalle Korhonen
>             Fix For: 1.3.0
>
>
> Funny as it is, though we have AuthenticationListener interface, we don't have a way of adding or removing these listeners in the API (you can access AbstractAuthenticator's listener collection if your Authenticator extends it).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (SHIRO-233) Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it

Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/SHIRO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981488#action_12981488 ] 

Kalle Korhonen commented on SHIRO-233:
--------------------------------------

Sure, changed the title accordingly. Adding it to the default implementation only is not good enough though since users should not need to know the implementation details. I'll see how to best put it in.

> Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-233
>                 URL: https://issues.apache.org/jira/browse/SHIRO-233
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Specification API
>    Affects Versions: 0.9, 1.0.0, 1.1.0
>            Reporter: Kalle Korhonen
>            Assignee: Kalle Korhonen
>             Fix For: 1.2.0
>
>
> Funny as it is, though we have AuthenticationListener interface, we don't have a way of adding or removing these listeners in the API (you can access AbstractAuthenticator's listener collection if your Authenticator extends it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (SHIRO-233) Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it

Posted by "Kalle Korhonen (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/SHIRO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kalle Korhonen updated SHIRO-233:
---------------------------------

    Summary: Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it  (was: Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface)

> Introduce AuthenticationListenerRegistrar interface and add addAuthenticationListener() and removeAuthenticationListener() operations to it
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-233
>                 URL: https://issues.apache.org/jira/browse/SHIRO-233
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Specification API
>    Affects Versions: 0.9, 1.0.0, 1.1.0
>            Reporter: Kalle Korhonen
>            Assignee: Kalle Korhonen
>             Fix For: 1.2.0
>
>
> Funny as it is, though we have AuthenticationListener interface, we don't have a way of adding or removing these listeners in the API (you can access AbstractAuthenticator's listener collection if your Authenticator extends it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SHIRO-233) Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface

Posted by "Les Hazlewood (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/SHIRO-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981441#action_12981441 ] 

Les Hazlewood commented on SHIRO-233:
-------------------------------------

Upon looking at this further, I don't feel that the Authenticator
interface should be changed - supporting listeners is an additional
feature IMO.  That is, just because an Authenticator exists, it
doesn't necessarily mean that listeners can be supported (depending on
the environment).

I believe we instead need to make an AuthenticationListenerRegistrar
interface and that should have the add/remove methods and the default
Authenticator implementation(s) should implement the
AuthenticationListenerRegistrar interface.  This achieves the same
result and is a little 'cleaner' IMO.

Any objections?

Les




> Add addAuthenticationListener() and removeAuthenticationListener() operations to Authenticator interface
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SHIRO-233
>                 URL: https://issues.apache.org/jira/browse/SHIRO-233
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Specification API
>    Affects Versions: 0.9, 1.0.0, 1.1.0
>            Reporter: Kalle Korhonen
>            Assignee: Kalle Korhonen
>             Fix For: 1.2.0
>
>
> Funny as it is, though we have AuthenticationListener interface, we don't have a way of adding or removing these listeners in the API (you can access AbstractAuthenticator's listener collection if your Authenticator extends it).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.