You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "vvchernov (via GitHub)" <gi...@apache.org> on 2023/02/17 06:53:17 UTC
[GitHub] [tvm] vvchernov opened a new pull request, #14019: WIP: [ONNX][TORCH] Replace scatter op by scatter_elements
vvchernov opened a new pull request, #14019:
URL: https://github.com/apache/tvm/pull/14019
ScatterElements has all functionality of Scatter and there is no limits for input data rank (1<= rank <= 4 in scatter implementation). It is implementation of the plan from the [PR](https://github.com/apache/tvm/pull/13894).
**Note**: On front-end sides scatter op still exists, but its back-end implementation is replaced by scatter_elements to remove duplicates and extend applicability conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vvchernov commented on pull request #14019: WIP: [ONNX][TORCH] Replace scatter op by scatter_elements
Posted by "vvchernov (via GitHub)" <gi...@apache.org>.
vvchernov commented on PR #14019:
URL: https://github.com/apache/tvm/pull/14019#issuecomment-1439835740
Hello @AndrewZhaoLuo! Could you review this PR? But take into account that it should be merged after the [PR](https://github.com/apache/tvm/pull/14008)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14019: WIP: [ONNX][TORCH] Replace scatter op by scatter_elements
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14019:
URL: https://github.com/apache/tvm/pull/14019#issuecomment-1434175572
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @KJlaccHoeUM9l, @shingjan, @yelite <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #14019: WIP: [ONNX][TORCH] Replace scatter op by scatter_elements
Posted by "AndrewZhaoLuo (via GitHub)" <gi...@apache.org>.
AndrewZhaoLuo commented on PR #14019:
URL: https://github.com/apache/tvm/pull/14019#issuecomment-1442397251
Awesome, I think cursory glance it looks good, but can you rebase after I merged your previous scatter_add commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vvchernov commented on pull request #14019: WIP: [ONNX][TORCH] Replace scatter op by scatter_elements
Posted by "vvchernov (via GitHub)" <gi...@apache.org>.
vvchernov commented on PR #14019:
URL: https://github.com/apache/tvm/pull/14019#issuecomment-1442825110
Hello @AndrewZhaoLuo! Thanks for merge previous PR, I rebased this branch on the top of the main, could you see it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo merged pull request #14019: [ONNX][TORCH] Replace scatter op by scatter_elements
Posted by "AndrewZhaoLuo (via GitHub)" <gi...@apache.org>.
AndrewZhaoLuo merged PR #14019:
URL: https://github.com/apache/tvm/pull/14019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org