You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/11/15 02:49:07 UTC
[PR] Fix case where pip requiremet version starts with != [airflow]
potiuk opened a new pull request, #35645:
URL: https://github.com/apache/airflow/pull/35645
Github provider has package starting with `!=` and the documentation generation had a bug (for a long time) to split the package versions wrongly in this case.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix case where pip requiremet version starts with != [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35645:
URL: https://github.com/apache/airflow/pull/35645#issuecomment-1812325526
> Look nice.
>
> What do you think if as follow up we would migrate from custom regex to the [`packaging`](https://packaging.pypa.io/en/stable/requirements.html) library?
Sure. PRS are more welcome. One of the reasons why I now work on moving all the code for packaging to `breeze` is to make it easier to contribute, tests and debug so PRs are most welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix case where pip requiremet version starts with != [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35645:
URL: https://github.com/apache/airflow/pull/35645#discussion_r1393574723
##########
airflow/providers/github/__init__.py:
##########
@@ -39,5 +39,5 @@
"2.5.0"
):
raise RuntimeError(
- f"The package `apache-airflow-providers-github:{__version__}` requires Apache Airflow 2.5.0+"
Review Comment:
Latest template applied here as well (cc: @eladkal - this the case whe you can use `--reapply-templates-only`
Changes in docs were done with (after implementing the fix)
```
breeze release-management prepare-provider-documentation github --reapply-templates-only
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix case where pip requiremet version starts with != [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35645:
URL: https://github.com/apache/airflow/pull/35645#discussion_r1393574723
##########
airflow/providers/github/__init__.py:
##########
@@ -39,5 +39,5 @@
"2.5.0"
):
raise RuntimeError(
- f"The package `apache-airflow-providers-github:{__version__}` requires Apache Airflow 2.5.0+"
Review Comment:
Latest template applied here as well (cc: @eladkal - this the case whe you can use `--reapply-templates-only`
Changes in docs were done with:
```
breeze release-management prepare-provider-documentation github --reapply-templates-only
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix case where pip requiremet version starts with != [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #35645:
URL: https://github.com/apache/airflow/pull/35645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org