[GitHub] [maven-wrapper] michael-o commented on a diff in pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r875146529


##########
maven-wrapper-distribution/src/resources/mvnw:
##########
@@ -198,6 +198,8 @@ else
     if [ "$MVNW_VERBOSE" = true ]; then
       echo "Downloading from: $wrapperUrl"
     fi
+    # Remove invalid line endings from wrapperUrl
+    wrapperUrl=${wrapperUrl%$'\r'}

Review Comment:
   Where does the URL come from? Do we need to fix the line ending of this resource in Git?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org