You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/10/27 13:20:59 UTC

[Bug 58557] Shift hyperlinks when shifting rows in XSSFSheet

https://bz.apache.org/bugzilla/show_bug.cgi?id=58557

--- Comment #1 from Javen ONeal <ja...@gmail.com> ---
Created attachment 33227
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33227&action=edit
shift hyperlinks in XSSFSheet.shiftRows

Thanks Alessandro for putting together a patch for XSSFRows.shiftRows for
shifting the anchor points of hyperlinks.
I wrote a unit test for your code to make sure it won't cause problems with
existing and future projects.

Two minor changes:
1. Hyperlinks on rows that are getting deleted (overwritten by the shifted
rows) also need to be deleted.
2. I made XSSFHyperlink.setCellReference internal-public rather than using 
XSSFHyperlink.getCTHyperlink method (which is unfortunately already
public--probably need to do some refactoring to get that back to protected--for
now I'm making getCTHyperlink internal-public). In general, no one should need
to know about the CT* classes.

Please take a look at the code and let me know if I'm missing anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org