You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/06 06:22:35 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request, #3183: [build] fix master branch broken http-core license check
Shoothzj opened a new pull request, #3183:
URL: https://github.com/apache/bookkeeper/pull/3183
### Changes
- the bkctl and bk-server has different `http-core` version
- unify the `http-core` version to 4.4.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183#issuecomment-1090025895
LGTM (already approved the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 merged pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
dlg99 merged PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183#issuecomment-1090000705
@nicoloboschi I thinks it's not update the line, but add the `http-core` version, I made some changes, please take a look :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183#issuecomment-1089977315
we should keep the dependencies up-to-date in gradle.build
it should be enough to update this line https://github.com/apache/bookkeeper/blob/d4eba629504930ca6179dee220e075b489c193a7/dependencies.gradle#L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183#issuecomment-1090047683
@merlimat @pkumar-singh @dlg99 Could you please help merging this PR to solve master broken check. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183#issuecomment-1089937245
> what about Gradle?
@nicoloboschi I am not familiar with gradle, let me work on it this weekend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #3183: [build] fix master branch broken http-core license check
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #3183:
URL: https://github.com/apache/bookkeeper/pull/3183#issuecomment-1089881542
what about Gradle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org