[GitHub] [hbase] javierluca commented on pull request #3048: HBASE-25663 Make graceful_stop localhostname compare match even if fqdn

[GitBox <gi...@apache.org>]

javierluca commented on pull request #3048:
URL: https://github.com/apache/hbase/pull/3048#issuecomment-799958984


   @saintstack In my opinion, your change was better because we could use "localhost" as argument, and that will work very well with `regionservers.sh` which will bypass the ssh section that does not work well with secured clusters:
   https://github.com/apache/hbase/blob/59ec375d679dcbf1701a92d4206ecc676a8fb069/bin/regionservers.sh#L61-L64
   
   Just needed to address the `stripServer` issue.
   May be something like this will do it?
   ```shell
   unload_hostname="$hostname"
   if [[ "$hostname" == "localhost" ]]; then
     unload_hostname=`/bin/hostname -f`
   fi
   unload_args="--filename $filename --maxthreads $maxthreads $noack --operation unload \
   --timeout $movetimeout --regionserverhost $unload_hostname"
   ```
   If you don't mind, I would like to submit a patch including the changes of this PR + above fix for the RegionMover.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org