You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/03/28 21:48:50 UTC
[GitHub] [incubator-hudi] n3nash commented on a change in pull request #620:
Fix HUDI-27 : Support num_cores > 1 for writing through spark
n3nash commented on a change in pull request #620: Fix HUDI-27 : Support num_cores > 1 for writing through spark
URL: https://github.com/apache/incubator-hudi/pull/620#discussion_r270212508
##########
File path: hoodie-client/src/main/java/com/uber/hoodie/io/storage/HoodieWrapperFileSystem.java
##########
@@ -536,8 +536,9 @@ public void completeLocalOutput(Path fsOutputFile, Path tmpLocalFile) throws IOE
}
@Override
- public void close() throws IOException {
- fileSystem.close();
+ public void close() {
Review comment:
Are we depending on the JVM shutdown to automatically close() or should we register it in the hook ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services