You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/26 09:59:17 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #6324: [Function][Vectorization] Vectorized ltrim and rtrim function to speedup performance
xinghuayu007 opened a new pull request #6324:
URL: https://github.com/apache/incubator-doris/pull/6324
## Proposed changes
Currently, `ltrim` and `rtrim` function can only compare one character with blank at a time. For 128 bits register, it can compare 16 characters at a time using SIMD. Therefore, using SIMD can speedup performance greatly. When there is less than 2 blanks, vetorized-ltrim has the same performance with non-vectorized-ltrim, but when blanks are more than 3, performance can be improved more than 2-3 times. Here are the test results:
**tests 1000 times, the unit is ns**
**ltrim function:**
2 blanks
vectorization: 60944
normal: 68471
3 blanks
vectorization: 70170
normal: 83194
8 blanks
vectorization: 75192
normal: 152855
22 blanks
wangxixu-vectorization: 77532
wangxixu-normal: 255719
**rtrim functions:**
2 blanks
vectorization: 88203
normal: 122999
3 blanks
vectorization: 79561
normal: 130995
8 blanks
vectorization: 15061465
normal: 2498301
22
vectorization: 96263
normal: 316270
_**The code refers no any other system, implemented by myself.**_
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on pull request #6324: [Function][Vectorization] Vectorized ltrim and rtrim function to speedup performance
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #6324:
URL: https://github.com/apache/incubator-doris/pull/6324#issuecomment-917793450
> @xinghuayu007 , good job ! currently doris-vectorized is working on project [doris-vectorized](https://github.com/doris-vectorized/doris-vectorized)
> some issues write todo list. you can join us if you are willing to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on pull request #6324: [Function][Vectorization] Vectorized ltrim and rtrim function to speedup performance
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on pull request #6324:
URL: https://github.com/apache/incubator-doris/pull/6324#issuecomment-917793815
> @xinghuayu007 , good job ! currently doris-vectorized is working on project [doris-vectorized](https://github.com/doris-vectorized/doris-vectorized)
> some issues write todo list. you can join us if you are willing to.
Ok. I will join it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt commented on pull request #6324: [Function][Vectorization] Vectorized ltrim and rtrim function to speedup performance
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on pull request #6324:
URL: https://github.com/apache/incubator-doris/pull/6324#issuecomment-917324526
@xinghuayu007 , good job ! currently doris-vectorized is working on project [doris-vectorized](https://github.com/doris-vectorized/doris-vectorized)
some issues write todo list. you can join us if you are willing to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 closed pull request #6324: [Function][Vectorization] Vectorized ltrim and rtrim function to speedup performance
Posted by GitBox <gi...@apache.org>.
xinghuayu007 closed pull request #6324:
URL: https://github.com/apache/incubator-doris/pull/6324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org