You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "prosgarz35 (via GitHub)" <gi...@apache.org> on 2026/09/28 07:42:09 UTC

[PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

prosgarz35 opened a new pull request, #3213:
URL: https://github.com/apache/james-project/pull/3213

   ## Description
   
   ### Context & Problem Statement
   In `BlobMailRepository`, multiple mail repositories may share the same underlying BlobStore and bucket. Previously, several critical issues existed in repository isolation, cleanup, and life-cycle management:
   
   1. **Unbounded `removeAll()` Deletions (Cross-Repository Data Loss):**
      `removeAll()` called `listBlobs()` across the entire bucket without scoping to the repository's path prefix. As a result, invoking `removeAll()` on a single repository wiped out metadata and MIME blobs belonging to all other mail repositories sharing the same bucket.
   2. **Missing Ownership & Cross-Repository MIME Reference Protection:**
      Operations blindly trusted metadata and MIME blob references. If a corrupted, forged, or cross-referenced metadata entry pointed to MIME blobs belonging to a different repository, operations like `remove()` or `removeAll()` could delete foreign MIME data, and `retrieve()` could leak foreign emails.
   3. **MIME Blob Leaks on Mail Overwrite:**
      Calling `store(mail)` with an existing `MailKey` overwrote the metadata entry with new MIME blob IDs but left the superseded header and body MIME blobs orphaned in the blobstore.
   4. **Stream Leaks & Corrupted Metadata Resiliency:**
      Metadata decoding did not reliably close underlying streams via `Using.resource`. Furthermore, non-JSON or schema-mismatched blobs encountered during enumeration or retrieval could crash operations rather than being gracefully skipped.
   
   ### Proposed Changes
   
   #### 1. Path-Scoped Listing & Verification (`ownedMails` and `readOwned`)
   - Scoped metadata blob listing to the repository's prefix using `listBlobs(bucket, url.getPath.asString() + "/")`.
   - Implemented `readOwned(id: MailPartsId)` as a centralized gatekeeper for all operations (`retrieve`, `remove`, `removeAll`, `store`, `list`, `size`):
     - Validates that the metadata payload's mail name matches the expected blob ID (`mailMetadataBlobIdFactory.of(mail.getName) == id.metadataBlobId`).
     - Enforces `isOwnedMimePart`: verifies that both `headerBlobId` and `bodyBlobId` reside strictly under the repository's expected MIME path prefix (`<repoPath>/mimeMessagedata/`). Any foreign MIME references are rejected.
     - Gracefully ignores missing (`ObjectNotFoundException`), malformed (`JsonParseException`), or invalid schema (`JsResultException`) metadata entries.
   
   #### 2. Cross-Repository Isolation & Progress Tracking
   - Implemented `removeAll(progressCallback: Consumer[MailKey])` and updated `removeAll()` to iterate exclusively over `ownedMails()`, deleting MIME parts followed by metadata blobs, and reporting deleted keys via callback.
   - Fixed `size` and `list` to count/iterate only valid, owned mails.
   - Updated `remove(key)` to delete blobs only after ownership and MIME prefix validation pass.
   
   #### 3. Cleanup of Superseded MIME Blobs on Overwrite
   - In `store(mc: Mail)`, checked for existing owned metadata before persisting the new mail.
   - If overwriting an existing key, the superseded MIME blobs are asynchronously deleted with a backoff retry (`Retry.backoff(2, Duration.ofMillis(50))`). If deletion exhausts retries, a warning is logged with the specific blob IDs, preventing silent data leakage while keeping the primary store operation reliable.
   
   #### 4. Safe Resource Handling
   - Wrapped `Store.CloseableByteSource` stream decoding in `Using.resource` within `MailMetadataDecoder` to guarantee stream closure.
   
   ---
   
   ### Verification & Testing
   - Added regression tests in `BlobMailRepositoryTest.java`:
     - `removeAllShouldNotAffectOtherRepositories()`: Verifies that clearing one repository leaves other repositories and their MIME blobs intact.
     - `overwriteShouldCleanOldMimeBlobs()`: Verifies that updating an existing mail cleans up superseded header/body blobs.
   - Added comprehensive failure and isolation scenarios in `BlobMailRepositoryFailureTest.java` and `blob-mailrepository-original-fixture.json`:
     - Malformed and corrupt metadata handling.
     - Foreign MIME reference rejection.
     - Stream leak prevention tests.
   - Successfully verified with `mvn test-compile checkstyle:check -pl server/mailrepository/mailrepository-blob` (0 Checkstyle violations).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5872954516

   > Also storage format changed.
   > 
   > I'd be cautious with retro compatibility and explicitly test this: write some blobs by hand according to how they were previously stored and ensure that repository content is still redable with new code.
   > 
   > if we can avoid a breaking change...
   
   we can avoid it for now but format needed to change in future i cant remember correctly but there problem with parsing json or something so no way in current format fully fix this problems


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5873101472

   You don't get it - if we break retro compatibility, we need to come up with a migration trategy which I'd like to avoid.
   I would prefer to maintain retro compatibility.
   
   Also @jeantil you might want to review this...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5904434195

   What you think about it Dear @chibenwa ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4120036352


##########
server/mailrepository/mailrepository-blob/src/test/java/org/apache/james/mailrepository/blob/BlobMailRepositoryTest.java:
##########
@@ -71,8 +74,108 @@ public MailRepository retrieveRepository(MailRepositoryPath path) {
     }
 
     @Test
-    @Disabled("This repository removes blobs rather than mails: it can not tell which of them back a mail")
+    @Disabled("BlobMailRepository key is a blobId with full path prefix, while MailRepositoryContract expects logical mail key")
     @Override
     public void removeAllShouldReportTheRemovedMails() {
     }
+
+    @Test
+    void removeAllShouldBeIsolatedAcrossRepositories() throws Exception {

Review Comment:
   Do we have a test
   var/mail/error do not list var/mail/error-backup content ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-6139801043

   Thanks for sharing.
   
   Health first. Take time needed for recovery, if needed we would take care of the follow ups and do not hesitate to ask for help.
   
   Best regards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4120022771


##########
server/mailrepository/mailrepository-blob/src/test/java/org/apache/james/mailrepository/blob/BlobMailRepositoryTest.java:
##########
@@ -71,8 +74,108 @@ public MailRepository retrieveRepository(MailRepositoryPath path) {
     }
 
     @Test
-    @Disabled("This repository removes blobs rather than mails: it can not tell which of them back a mail")
+    @Disabled("BlobMailRepository key is a blobId with full path prefix, while MailRepositoryContract expects logical mail key")
     @Override
     public void removeAllShouldReportTheRemovedMails() {
     }
+
+    @Test
+    void removeAllShouldBeIsolatedAcrossRepositories() throws Exception {

Review Comment:
   Those tests are generic and should be moved to the contract IMO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4132571891


##########
server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepository.scala:
##########
@@ -169,35 +180,96 @@ class BlobMailRepository(val mailMetaDataBlobStore: BlobStore,
       .map(mailPartsId => mailPartsId.toMailKey)
       .block()
 
+    oldMimeId.foreach(mimeId =>
+      SMono.fromPublisher(mimeMessageStore.delete(mimeId))
+        .retryWhen(Retry.backoff(2, Duration.ofMillis(50)))
+        .doOnError(e => LOGGER.warn("Failed to delete superseded MIME blobs {} and {} for mail {} in {}",
+          mimeId.getHeaderBlobId.asString(), mimeId.getBodyBlobId.asString(), mc.getName, url.asString(), e))
+        .onErrorResume(_ => SMono.empty)
+        .block()
+    )

Review Comment:
   We should have IMO a plan for dropping those exta reads.
   
   My proposition is to:
    - Leave BlobMailRepository -> untouched but marked as **deprecated** and to be removed after 3.10.0 release
    - Have a BlobMailRepositoryV2 which do NOT handle retrocompatibility and adopt whatever format is most suited
    - Write a upgrade instruction saying that BlobMailRepository will be dropped next release. That users can configure both `BlobMailRepository` and `BlobMailRepositoryV2` playing mailrepositorystore.xml config and move messages via webadmin. They shall do that prior 3.11.0.
   
   Exact steps would be:
    - A. add blobv2:// backed by BlobMailRepositoryV2 in mailrepositorystore.xml
    - A. and Update mailet container to use blobv2://
    - A. and reboot james
    - B. move things from blob:// to blobv2:// cf webadmin API
    - C: Set blob:// to be backed by BlobMailRepositoryV2
    - C: and Update mailet container to use blob://
    - C: and remove blobv2:// section
    - C: and reboot
   
   CF https://james.staged.apache.org/james-project/3.10.0/servers/distributed/operate/webadmin.html#_moving_mails_from_a_mail_repository_to_another
   
   I believe it provides a clear discontinuation plan with limited compexity on our hand and limits retro compatibility concerns: our hands are free to make optimal choices.
   
   Opinion ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4133492327


##########
server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepository.scala:
##########
@@ -169,35 +180,96 @@ class BlobMailRepository(val mailMetaDataBlobStore: BlobStore,
       .map(mailPartsId => mailPartsId.toMailKey)
       .block()
 
+    oldMimeId.foreach(mimeId =>
+      SMono.fromPublisher(mimeMessageStore.delete(mimeId))
+        .retryWhen(Retry.backoff(2, Duration.ofMillis(50)))
+        .doOnError(e => LOGGER.warn("Failed to delete superseded MIME blobs {} and {} for mail {} in {}",
+          mimeId.getHeaderBlobId.asString(), mimeId.getBodyBlobId.asString(), mc.getName, url.asString(), e))
+        .onErrorResume(_ => SMono.empty)
+        .block()
+    )

Review Comment:
   > https://james.staged.apache.org/james-project/3.10.0/servers/distributed/operate/webadmin.html#_moving_mails_from_a_mail_repository_to_another its good feature!
   
   We try to sometime have good ideas ^^



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-6138807912

   > Hello @prosgarz35
   > 
   > It took me a while to understand the context.
   > 
   > I'm pretty sure "special needs" was meant as "specific requirements": we are all writing in a non-native language here, and that expression carries a connotation in English its author very likely did not intend - nor did I before I checked the dictionnary. Suggesting a fork is a common path in open source to prove a backend can be maintained over time, not a dismissal of your use case.
   > 
   > That discussion was about adding new storage backends upstream. It does not change anything for this PR, which is reviewed on its own merits.
   > 
   > Best regards,
   > 
   > Benoit
   
   Thank you, Benoit, for stepping in and clarifying the context. I’d certainly like to believe he meant no harm with the original comment, and I'm glad to move forward from this.
   On a separate note, I have recently come down with a severe case of strep throat and am currently barely able to stand. Because of this, I need to take some time to recover, but I look forward to focusing on the technical side of the contribution as soon as I'm back on my feet. Warm regards!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-6138536481

   Hello @prosgarz35 
   
   I'm sorry I do not relly get the last comment. What are we speaking of when speaking of "special need"?
   
   Friction is part of free software. Without it it would be too easy. It's the act of confronting  ideas together that helps building better software. 
   
   Communication sometime get rough. When on the receiving hand, we all need to assume best intention of our counterparts. We all use a non native language we all have different cultures. We need to go beyond, build mutual understanding and understand each other motivations and concerns. 
   
   Both friction and communication is what allow building consensus, the blood of the ASF :-)
   
   Warm regards,
   
   Benoit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5872821578

   Can we also please create a JIRA for the underlying bug please ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4132673517


##########
server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepository.scala:
##########
@@ -169,35 +180,96 @@ class BlobMailRepository(val mailMetaDataBlobStore: BlobStore,
       .map(mailPartsId => mailPartsId.toMailKey)
       .block()
 
+    oldMimeId.foreach(mimeId =>
+      SMono.fromPublisher(mimeMessageStore.delete(mimeId))
+        .retryWhen(Retry.backoff(2, Duration.ofMillis(50)))
+        .doOnError(e => LOGGER.warn("Failed to delete superseded MIME blobs {} and {} for mail {} in {}",
+          mimeId.getHeaderBlobId.asString(), mimeId.getBodyBlobId.asString(), mc.getName, url.asString(), e))
+        .onErrorResume(_ => SMono.empty)
+        .block()
+    )

Review Comment:
   I surely like idea, but not sure i can make so complicated task, i try it ! So really that needed? We have something already like v2 ?
   
   https://james.staged.apache.org/james-project/3.10.0/servers/distributed/operate/webadmin.html#_moving_mails_from_a_mail_repository_to_another its good feature!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5902933958

   this PR going be V2 blueprint


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-6127974101

   > Hello @prosgarz35
   > 
   > Can I ask you for the state of this work?
   > 
   > Do you plan to further work on this topic?
   > 
   > Best regards,
   > 
   > Benoit
   
   I have to admit, hearing my feedback framed as 'special needs' caught me a bit off guard and felt a bit discouraging. But looking past that, maybe it's worth following his suggestion, even if my only 'special need' was just wanting more than a single option for a non-distributed system.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-6126870428

   Hello @prosgarz35 
   
   Can I ask you for the state of this work?
   
   Do you plan to further work on this topic?
   
   Best regards,
   
   Benoit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5873194989

   > Can we also please create a JIRA for the underlying bug please ?
   
   tomorrow :) 22.30  now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5950542407

   > @quantranhong1999 can i ask you do this too? Thanks :3
   
   done ^^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-6138606663

   Hello @prosgarz35 
   
   It took me a while to understand the context. 
   
   I'm pretty sure "special needs" was meant as "specific requirements": we are all writing in a non-native language here, and that expression carries a connotation in English its author very likely did not intend - nor did I before I checked the dictionnary. Suggesting a fork is a common path in open source to prove a backend can be maintained over time, not a dismissal of your use case.
   
   That discussion was about adding new storage backends upstream. 
   It does not change anything for this PR, which is reviewed on its own merits.
   
   Best regards,
   
   Benoit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5873146699

   > You don't get it - if we break retro compatibility, we need to come up with a migration trategy which I'd like to avoid. I would prefer to maintain retro compatibility.
   > 
   > Also @jeantil you might want to review this...
   
   yeah i get it for now we must have backward fully compability


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4143557177


##########
server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepositoryV2BlobReferenceSource.scala:
##########
@@ -0,0 +1,73 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one   *
+ * or more contributor license agreements.  See the NOTICE file *
+ * distributed with this work for additional information        *
+ * regarding copyright ownership.  The ASF licenses this file   *
+ * to you under the Apache License, Version 2.0 (the            *
+ * "License"); you may not use this file except in compliance   *
+ * with the License.  You may obtain a copy of the License at   *
+ *                                                              *
+ *   http://www.apache.org/licenses/LICENSE-2.0                 *
+ *                                                              *
+ * Unless required by applicable law or agreed to in writing,   *
+ * software distributed under the License is distributed on an  *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
+ * KIND, either express or implied.  See the License for the    *
+ * specific language governing permissions and limitations      *
+ * under the License.                                           *
+ ****************************************************************/
+
+package org.apache.james.mailrepository.blob
+
+import jakarta.inject.Inject
+import org.apache.james.blob.api.{BlobId, BlobReferenceSource}
+import org.apache.james.mailrepository.api.{MailRepositoryStore, Protocol}
+import org.slf4j.LoggerFactory
+import reactor.core.publisher.Flux
+
+import scala.jdk.CollectionConverters._
+
+/**
+ * Tells the blob store garbage collector ([[org.apache.james.server.blob.deduplication.BloomFilterGCAlgorithm]])
+ * which MIME blobs (header + body) are still referenced by every
+ * [[BlobMailRepositoryV2]] instance, so GC does not reclaim them as orphaned.
+ *
+ * Without this, mails stored via [[BlobMailRepositoryV2]] would have their
+ * MIME blobs deleted on the next GC pass, since GC only keeps blobs that
+ * some [[BlobReferenceSource]] explicitly reports as referenced.
+ *
+ * Unlike the Cassandra/Postgres siblings - which each own a single global
+ * DAO keyed by repository name - this module creates one independent
+ * [[BlobMailRepositoryV2]] instance per [[org.apache.james.mailrepository.api.MailRepositoryUrl]]
+ * (the URL path is baked into that instance's blob id prefix). This source
+ * therefore goes through [[MailRepositoryStore]] to discover every path
+ * registered under the "blobv2" protocol, and asks each corresponding
+ * repository instance directly for its referenced MIME parts.
+ *
+ * MUST be registered (e.g. via a Guice Multibinder<BlobReferenceSource>,
+ * see BlobstoreMailRepositoryModule) for every deployment using
+ * [[BlobMailRepositoryV2]].
+ */
+class BlobMailRepositoryV2BlobReferenceSource @Inject()(mailRepositoryStore: MailRepositoryStore)
+  extends BlobReferenceSource {
+
+  private val LOGGER = LoggerFactory.getLogger(classOf[BlobMailRepositoryV2BlobReferenceSource])
+  private val BLOBV2_PROTOCOL = new Protocol("blobv2")
+
+  private def blobV2Repositories: Iterator[BlobMailRepositoryV2] =
+    mailRepositoryStore.getUrls.iterator().asScala
+      .filter(_.getProtocol == BLOBV2_PROTOCOL)
+      .map(_.getPath)
+      .distinct
+      .flatMap(path => mailRepositoryStore.getByPath(path).iterator().asScala)
+      .collect { case repository: BlobMailRepositoryV2 => repository }
+
+  override def listReferencedBlobs(): Flux[BlobId] =
+    Flux.fromIterable(blobV2Repositories.iterator.to(Iterable).asJava)
+      .flatMap(repository => repository.listReferencedMimeParts
+        .onErrorResume(e => {
+          LOGGER.warn("Failed listing referenced MIME parts for a BlobMailRepositoryV2 instance", e)
+          Flux.empty()
+        }))

Review Comment:
   ```suggestion
   ```
   
   Swallowing failures result in data loss. We MUST propagate.



##########
server/mailrepository/mailrepository-blob/src/test/java/org/apache/james/mailrepository/blob/BlobMailRepositoryV2Test.java:
##########
@@ -0,0 +1,87 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one   *
+ * or more contributor license agreements.  See the NOTICE file *
+ * distributed with this work for additional information        *
+ * regarding copyright ownership.  The ASF licenses this file   *
+ * to you under the Apache License, Version 2.0 (the            *
+ * "License"); you may not use this file except in compliance   *
+ * with the License.  You may obtain a copy of the License at   *
+ *                                                              *
+ *   http://www.apache.org/licenses/LICENSE-2.0                 *
+ *                                                              *
+ * Unless required by applicable law or agreed to in writing,   *
+ * software distributed under the License is distributed on an  *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
+ * KIND, either express or implied.  See the License for the    *
+ * specific language governing permissions and limitations      *
+ * under the License.                                           *
+ ****************************************************************/
+
+package org.apache.james.mailrepository.blob;
+
+import org.apache.james.blob.api.PlainBlobId;
+import org.apache.james.blob.mail.MimeMessageStore;
+import org.apache.james.blob.memory.MemoryBlobStoreDAO;
+import org.apache.james.blob.memory.MemoryBlobStoreFactory;
+import org.apache.james.mailrepository.MailRepositoryContract;
+import org.apache.james.mailrepository.api.MailRepository;
+import org.apache.james.mailrepository.api.MailRepositoryPath;
+import org.apache.james.mailrepository.api.MailRepositoryUrl;
+import org.apache.james.mailrepository.api.Protocol;
+import org.jetbrains.annotations.NotNull;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Skeleton contract test for {@link BlobMailRepositoryV2}.
+ *
+ * Mirrors {@link BlobMailRepositoryTest}: this only exercises the
+ * generic {@link MailRepositoryContract} behaviour. V2-specific
+ * isolation/GC-reference scenarios are intentionally left out of this
+ * PR's scope and will be addressed in a follow-up PR, per review
+ * feedback (cf feedback.md / PR #3213 discussion with @chibenwa).
+ */
+class BlobMailRepositoryV2Test implements MailRepositoryContract {
+
+    private MailRepository blobMailRepositoryV2;
+    private PlainBlobId.Factory blobIdFactory;
+    private MemoryBlobStoreDAO blobStore;
+    private MimeMessageStore.Factory mimeMessageStoreFactory;
+    private BlobMailRepositoryV2Factory blobMailRepositoryV2Factory;
+
+    @BeforeEach
+    void setup() {
+        blobIdFactory = new PlainBlobId.Factory();

Review Comment:
   We need a test with GenerationAwareBlobId.Factory



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4143492615


##########
server/mailrepository/mailrepository-blob/src/test/java/org/apache/james/mailrepository/blob/BlobMailRepositoryV2Test.java:
##########
@@ -0,0 +1,87 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one   *
+ * or more contributor license agreements.  See the NOTICE file *
+ * distributed with this work for additional information        *
+ * regarding copyright ownership.  The ASF licenses this file   *
+ * to you under the Apache License, Version 2.0 (the            *
+ * "License"); you may not use this file except in compliance   *
+ * with the License.  You may obtain a copy of the License at   *
+ *                                                              *
+ *   http://www.apache.org/licenses/LICENSE-2.0                 *
+ *                                                              *
+ * Unless required by applicable law or agreed to in writing,   *
+ * software distributed under the License is distributed on an  *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
+ * KIND, either express or implied.  See the License for the    *
+ * specific language governing permissions and limitations      *
+ * under the License.                                           *
+ ****************************************************************/
+
+package org.apache.james.mailrepository.blob;
+
+import org.apache.james.blob.api.PlainBlobId;
+import org.apache.james.blob.mail.MimeMessageStore;
+import org.apache.james.blob.memory.MemoryBlobStoreDAO;
+import org.apache.james.blob.memory.MemoryBlobStoreFactory;
+import org.apache.james.mailrepository.MailRepositoryContract;
+import org.apache.james.mailrepository.api.MailRepository;
+import org.apache.james.mailrepository.api.MailRepositoryPath;
+import org.apache.james.mailrepository.api.MailRepositoryUrl;
+import org.apache.james.mailrepository.api.Protocol;
+import org.jetbrains.annotations.NotNull;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Skeleton contract test for {@link BlobMailRepositoryV2}.
+ *
+ * Mirrors {@link BlobMailRepositoryTest}: this only exercises the
+ * generic {@link MailRepositoryContract} behaviour. V2-specific
+ * isolation/GC-reference scenarios are intentionally left out of this
+ * PR's scope and will be addressed in a follow-up PR, per review
+ * feedback (cf feedback.md / PR #3213 discussion with @chibenwa).
+ */
+class BlobMailRepositoryV2Test implements MailRepositoryContract {
+
+    private MailRepository blobMailRepositoryV2;
+    private PlainBlobId.Factory blobIdFactory;
+    private MemoryBlobStoreDAO blobStore;
+    private MimeMessageStore.Factory mimeMessageStoreFactory;
+    private BlobMailRepositoryV2Factory blobMailRepositoryV2Factory;
+
+    @BeforeEach
+    void setup() {
+        blobIdFactory = new PlainBlobId.Factory();
+        blobStore = new MemoryBlobStoreDAO();
+        var mimeMessageBlobStore = MemoryBlobStoreFactory.builder()
+                .blobIdFactory(blobIdFactory)
+                .defaultBucketName()
+                .passthrough();
+        mimeMessageStoreFactory = new MimeMessageStore.Factory(mimeMessageBlobStore);
+        MailRepositoryPath path = MailRepositoryPath.from("var/mail/error");
+        blobMailRepositoryV2Factory = new BlobMailRepositoryV2Factory(blobStore, blobIdFactory, mimeMessageBlobStore.getDefaultBucketName());
+        blobMailRepositoryV2 = buildBlobMailRepositoryV2(path);
+    }
+
+    @NotNull
+    private MailRepository buildBlobMailRepositoryV2(MailRepositoryPath path) {
+        return blobMailRepositoryV2Factory.create(MailRepositoryUrl.fromPathAndProtocol(new Protocol("blobv2"), path));
+    }
+
+    @Override
+    public MailRepository retrieveRepository() {
+        return blobMailRepositoryV2;
+    }
+
+    @Override
+    public MailRepository retrieveRepository(MailRepositoryPath path) {
+        return buildBlobMailRepositoryV2(path);
+    }
+
+    @Test
+    @Disabled("This repository removes blobs rather than mails: it can not tell which of them back a mail")
+    @Override
+    public void removeAllShouldReportTheRemovedMails() {
+    }

Review Comment:
   That's a pity can't we manage to solve this one in v2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] BlobMailRepository: Isolate removeAll across mail repositories to prevent catastrophic data loss and cross-repository deletion [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #3213:
URL: https://github.com/apache/james-project/pull/3213#discussion_r4133509552


##########
server/mailrepository/mailrepository-blob/src/main/scala/org/apache/james/mailrepository/blob/BlobMailRepository.scala:
##########
@@ -169,35 +180,96 @@ class BlobMailRepository(val mailMetaDataBlobStore: BlobStore,
       .map(mailPartsId => mailPartsId.toMailKey)
       .block()
 
+    oldMimeId.foreach(mimeId =>
+      SMono.fromPublisher(mimeMessageStore.delete(mimeId))
+        .retryWhen(Retry.backoff(2, Duration.ofMillis(50)))
+        .doOnError(e => LOGGER.warn("Failed to delete superseded MIME blobs {} and {} for mail {} in {}",
+          mimeId.getHeaderBlobId.asString(), mimeId.getBodyBlobId.asString(), mc.getName, url.asString(), e))
+        .onErrorResume(_ => SMono.empty)
+        .block()
+    )

Review Comment:
   Cut it in small parts:
   
    - 1 PR for contract changes, @Disabled for BlobMailRepository
    - 1 PR for BlobMailRepositoryV2 alone 
    - 1 PR for deprecation and upgrade procedure.
    
    Smaller chunks makes things generally more manageable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "prosgarz35 (via GitHub)" <gi...@apache.org>.
prosgarz35 commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5950491506

   @quantranhong1999 can i ask you do this too? Thanks :3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


Re: [PR] Introduce BlobMailRepositoryV2 (skeleton) [james-project]

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #3213:
URL: https://github.com/apache/james-project/pull/3213#issuecomment-5960575319

   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[6]
   
   En échec depuis 3 builds (Depuis En échec#14 )
   A duré 0.16 s.
   Message d'erreur
   Expecting actual:
     []
   to contain exactly in any order:
     [MailKey{value=1_628_var/mail/error/mailMetadata/mail18},
       MailKey{value=1_628_var/mail/error/mailMetadata/mail4},
       MailKey{value=1_628_var/mail/error/mailMetadata/mail10}]
   but could not find the following elements:
     [MailKey{value=1_628_var/mail/error/mailMetadata/mail18},
       MailKey{value=1_628_var/mail/error/mailMetadata/mail4},
       MailKey{value=1_628_var/mail/error/mailMetadata/mail10}]
       
       
   Résultats des tests (26 échecs / ±0)
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[6]
   org.apache.james.mailrepository.blob.BlobMailRepositoryV2BlobReferenceSourceTest.listReferencedBlobsShouldPropagateErrorsWhenStoreFails
   org.apache.james.mailrepository.blob.BlobMailRepositoryV2Test.removeAllShouldReportTheRemovedMails
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.listShouldReturnStoredMailsKeys
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.mailRepositoriesShouldBeURLIsolated
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.removeAllShouldReportTheRemovedMails
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.removeShouldHaveNoEffectOnSizeWhenUnknownKeys
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.removeShouldnotAffectUnrelatedMails
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.removedMailShouldNotBeListed
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.removedMailsShouldNotBeListed
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.retrieveShouldReturnNullAfterRemoveAll
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.sizeShouldBeIncrementedByOneWhenDuplicates
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.sizeShouldReturnMailCount
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storeShouldHaveNoEffectOnSizeWhenAlreadyStoredMail
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[10]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[1]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[2]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[3]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[4]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[5]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[7]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[8]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingAndRemovingMessagesConcurrentlyShouldLeadToConsistentResult()[9]
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingMessageWithPerRecipientHeadersShouldAllowMultipleHeadersPerUser
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingMessageWithSameKeyTwiceShouldUpdateMessageAttributes
   org.apache.james.mailrepository.blob.GenerationAwareBlobMailRepositoryV2Test.storingMessageWithSameKeyTwiceShouldUpdateMessageContent
   
   Related I presume...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org