You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/10 03:08:23 UTC

[GitHub] [spark] HyukjinKwon commented on pull request #30481: [SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver

HyukjinKwon commented on pull request #30481:
URL: https://github.com/apache/spark/pull/30481#issuecomment-742206612


   @ulysses-you, is there any case we have to disable this configuration when `spark.sql.thriftServer.queryTimeout` is set? If no, let's remove the configuration in this PR, and set `interruptOnCancel` to `true` when `spark.sql.thriftServer.queryTimeout` is set.
   
   `spark.sql.thriftServer.queryTimeout` is not out yet so I think it's fine to add this behaviour.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org