You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/27 00:44:34 UTC
[GitHub] [incubator-inlong] GanfengTan opened a new pull request, #3963: [INLONG-3956][sort]add hive connector to support CDC to hive (#3956)
GanfengTan opened a new pull request, #3963:
URL: https://github.com/apache/incubator-inlong/pull/3963
fix UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3963: [INLONG-3956][Sort] Add Hive connector to support CDC
Posted by GitBox <gi...@apache.org>.
healchow merged PR #3963:
URL: https://github.com/apache/incubator-inlong/pull/3963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap commented on a diff in pull request #3963: [INLONG-3956][Sort] Add Hive connector to support CDC
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #3963:
URL: https://github.com/apache/incubator-inlong/pull/3963#discussion_r859400792
##########
inlong-sort/sort-single-tenant/pom.xml:
##########
@@ -84,11 +88,18 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${flink.scala.binary.version}</artifactId>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <artifactId>scala-parser-combinators_2.11</artifactId>
+ <groupId>org.scala-lang.modules</groupId>
+ </exclusion>
+ </exclusions>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-table-common</artifactId>
- </dependency>
+ <!-- <dependency>-->
+ <!-- <groupId>org.apache.flink</groupId>-->
+ <!-- <artifactId>flink-table-common</artifactId>-->
Review Comment:
remove pls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #3963: [INLONG-3956][Sort] Add Hive connector to support CDC
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #3963:
URL: https://github.com/apache/incubator-inlong/pull/3963#discussion_r859458121
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/ExtractNodeUtils.java:
##########
@@ -20,6 +20,8 @@
import com.google.common.base.Splitter;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
+import java.util.List;
Review Comment:
Please do not change the import order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org