You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Willis Blackburn (JIRA)" <ji...@apache.org> on 2011/01/02 14:14:45 UTC

[jira] Created: (WICKET-3299) Please un-deprecate WebApplication.mount

Please un-deprecate WebApplication.mount
----------------------------------------

                 Key: WICKET-3299
                 URL: https://issues.apache.org/jira/browse/WICKET-3299
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.5-M3
            Reporter: Willis Blackburn


WebApplication.mount is deprecated with the comment:

	 * @deprecated this is the same as {@code getRootRequestMapperAsCompound().add(mapper)}

Sure it's the same but mount(mapper) is much clearer.  And WebApplication.mountPage is the same as:

		getRootRequestMapperAsCompound().add(new MountedMapper(path, pageClass));

but it's not deprecated.  Wicket is full of shortcut functions (for example Component.setResponsePage is the same as getRequestCycle().setResponsePage(page));  why get rid of this one?


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-3299) Please un-deprecate WebApplication.mount

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3299.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4

Done with r1054407.
Additionally #mountPackage() is added to be consistent with 1.4. 

> Please un-deprecate WebApplication.mount
> ----------------------------------------
>
>                 Key: WICKET-3299
>                 URL: https://issues.apache.org/jira/browse/WICKET-3299
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>            Assignee: Martin Grigorov
>             Fix For: 1.5-M4
>
>
> WebApplication.mount is deprecated with the comment:
> 	 * @deprecated this is the same as {@code getRootRequestMapperAsCompound().add(mapper)}
> Sure it's the same but mount(mapper) is much clearer.  And WebApplication.mountPage is the same as:
> 		getRootRequestMapperAsCompound().add(new MountedMapper(path, pageClass));
> but it's not deprecated.  Wicket is full of shortcut functions (for example Component.setResponsePage is the same as getRequestCycle().setResponsePage(page));  why get rid of this one?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-3299) Please un-deprecate WebApplication.mount

Posted by "Willis Blackburn (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976521#action_12976521 ] 

Willis Blackburn commented on WICKET-3299:
------------------------------------------

Thanks! 

By the way I love the new URL mapping infrastructure.  It seems very natural and consistent.  The one in Wicket 1.3 always seemed more complicated than necessary.

Regards,
Willis







> Please un-deprecate WebApplication.mount
> ----------------------------------------
>
>                 Key: WICKET-3299
>                 URL: https://issues.apache.org/jira/browse/WICKET-3299
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>            Assignee: Martin Grigorov
>             Fix For: 1.5-M4
>
>
> WebApplication.mount is deprecated with the comment:
> 	 * @deprecated this is the same as {@code getRootRequestMapperAsCompound().add(mapper)}
> Sure it's the same but mount(mapper) is much clearer.  And WebApplication.mountPage is the same as:
> 		getRootRequestMapperAsCompound().add(new MountedMapper(path, pageClass));
> but it's not deprecated.  Wicket is full of shortcut functions (for example Component.setResponsePage is the same as getRequestCycle().setResponsePage(page));  why get rid of this one?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Assigned: (WICKET-3299) Please un-deprecate WebApplication.mount

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-3299:
---------------------------------------

    Assignee: Martin Grigorov

> Please un-deprecate WebApplication.mount
> ----------------------------------------
>
>                 Key: WICKET-3299
>                 URL: https://issues.apache.org/jira/browse/WICKET-3299
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>            Assignee: Martin Grigorov
>
> WebApplication.mount is deprecated with the comment:
> 	 * @deprecated this is the same as {@code getRootRequestMapperAsCompound().add(mapper)}
> Sure it's the same but mount(mapper) is much clearer.  And WebApplication.mountPage is the same as:
> 		getRootRequestMapperAsCompound().add(new MountedMapper(path, pageClass));
> but it's not deprecated.  Wicket is full of shortcut functions (for example Component.setResponsePage is the same as getRequestCycle().setResponsePage(page));  why get rid of this one?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.