You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/07/30 18:11:21 UTC
[GitHub] incubator-guacamole-client pull request #44: GUACAMOLE-5: Fix identifier val...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/44
GUACAMOLE-5: Fix identifier validity regression.
Pull request #38 introduced a regression which made it impossible to retrieve specific users. This is because the assumption driving #38 (that all identifiers within the JDBC auth are numeric strings) is incorrect. `User` objects within the JDBC auth have pure string identifiers which are not derived from internal numeric IDs and need not be numeric.
This change moves the validity checking from the base `ObjectModel` class into the object-specific `ModeledDirectoryObjectService` class, such that the `Directory` implementation itself can override the default numeric-only behavior if the objects truly do not require numeric identifiers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client identifier-validity-regression
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit 4ce6323088e03d5b7bf1f0f5b35987112f05b8b8
Author: Michael Jumper <mj...@apache.org>
Date: 2016-07-30T17:54:32Z
GUACAMOLE-5: Move identifier validity check to ModeledDirectoryObjectService. It must be object-specific, as not all objects have numeric identifiers in the database auth.
commit 804ddca75f23536630cd473c50acefbc837e3daa
Author: Michael Jumper <mj...@apache.org>
Date: 2016-07-30T17:56:09Z
GUACAMOLE-5: All strings are valid user identifiers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #44: GUACAMOLE-5: Fix identifier val...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---