You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "DarthData410 (via GitHub)" <gi...@apache.org> on 2023/04/29 12:10:25 UTC
[GitHub] [iceberg] DarthData410 opened a new pull request, #7472: mkdocs serve --strict mode generation WARNINGS fixes for pyarrow.py
DarthData410 opened a new pull request, #7472:
URL: https://github.com/apache/iceberg/pull/7472
Based on issue #7458 all pyarrow.py mkdocs WARNINGS have been resolved, following the guidelines documented as official supported styles: https://mkdocstrings.github.io/griffe/docstrings/#other-parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] DarthData410 commented on pull request #7472: mkdocs serve --strict mode generation WARNINGS fixes for io/pyarrow.py, io/fsspec.py and io/__init__.py
Posted by "DarthData410 (via GitHub)" <gi...@apache.org>.
DarthData410 commented on PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#issuecomment-1528815821
All updates need to resolve issue #7472 have been completed with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7472: mkdocs serve --strict mode generation WARNINGS fixes for all remaining pyiceberg *.py files
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#discussion_r1181259606
##########
python/pyiceberg/schema.py:
##########
@@ -783,7 +783,7 @@ def pre_order_visit(obj: Union[Schema, IcebergType], visitor: PreOrderSchemaVisi
because we don't use the pre-order traversal much.
Args:
- obj(Schema | IcebergType): An instance of a Schema or an IcebergType
+ obj (Schema | IcebergType): An instance of a Schema or an IcebergType
Review Comment:
```suggestion
obj (Schema, IcebergType): An instance of a Schema or an IcebergType
```
##########
python/pyiceberg/schema.py:
##########
@@ -714,7 +714,7 @@ def visit(obj: Union[Schema, IcebergType], visitor: SchemaVisitor[T]) -> T:
The function traverses the schema in post-order fashion
Args:
- obj(Schema | IcebergType): An instance of a Schema or an IcebergType
+ obj (Union[Schema | IcebergType]): An instance of a Schema or an IcebergType
Review Comment:
```suggestion
obj (Union[Schema, IcebergType]): An instance of a Schema or an IcebergType
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7472: Python: Fix warnings in documentation
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7472:
URL: https://github.com/apache/iceberg/pull/7472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] DarthData410 commented on pull request #7472: mkdocs serve --strict mode generation WARNINGS fixes for pyarrow.py
Posted by "DarthData410 (via GitHub)" <gi...@apache.org>.
DarthData410 commented on PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#issuecomment-1528775742
@Fokko I don't understand what trailing white space is failing on this PR now as well.
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook
Fixing python/pyiceberg/io/pyarrow.py
I had to research the proper formatting for the final fix in pyarrow.py, specifically at lines 318/319. This was failing based on the format of those comment lines. However having been updated, it seems this is also causing trailing white spaces... I will gladly fix this, I just don't see in the failed lint test exactly where the trailing white space line in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7472: Python: Fix warnings in documentation
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#issuecomment-1529130422
Thank you @DarthData410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7472: mkdocs serve --strict mode generation WARNINGS fixes for all remaining pyiceberg *.py files
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7472:
URL: https://github.com/apache/iceberg/pull/7472#discussion_r1181246500
##########
python/pyiceberg/schema.py:
##########
@@ -714,7 +714,7 @@ def visit(obj: Union[Schema, IcebergType], visitor: SchemaVisitor[T]) -> T:
The function traverses the schema in post-order fashion
Args:
- obj(Schema | IcebergType): An instance of a Schema or an IcebergType
+ obj (Schema | IcebergType): An instance of a Schema or an IcebergType
Review Comment:
Should we use the `Union` notation here as well?
##########
python/pyiceberg/transforms.py:
##########
@@ -709,8 +709,11 @@ def _(_type: IcebergType, value: int) -> str:
class UnknownTransform(Transform[S, T]):
"""A transform that represents when an unknown transform is provided
Args:
- source_type (IcebergType): An Iceberg `Type`
transform (str): A string name of a transform
+
+ Keyword Args:
+ source_type (IcebergType): An Iceberg `Type`
Review Comment:
I think it is better to just drop this one. An `UnknownTransform` doesn't really has a `source_type` since it is just a fallback transform in case we get an unexpected transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org