[GitHub] [dolphinscheduler] HomminLee commented on pull request #10440: [Fix][dolphinscheduler-spi] json parse support LocalDateTime

[GitBox <gi...@apache.org>]

HomminLee commented on PR #10440:
URL: https://github.com/apache/dolphinscheduler/pull/10440#issuecomment-1154850718

   The reason for #10403  is that after `mysql-connector-java` version `8.0.22`, `datatime` type in mysql will be convert to the `LocalDateTime` type in Java. In most places in dolphinscheduler, `LocalDateTime` will be handled by mybatis. But in `SqlTask`, `LocalDateTime` will be handled by `JSONUtils` in spi module and `JSONUtils` does not support parse `LocalDateTime`.
   From the principle of `the SPI should have only minimal dependencies`, I just add LocalDateTime serializer and not add dependencies `jackson-datatype-jsr310`.
   BTW, `JSONUtils` in spi module still not support `LocalDate` and `LocalTime`, and no use of them has been found so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org