[GitHub] [spark] zhouyifan279 commented on a diff in pull request #40645: [SPARK-43014] Do not overwrite `spark.app.submitTime` in k8s cluster mode driver

["zhouyifan279 (via GitHub)" <gi...@apache.org>]

zhouyifan279 commented on code in PR #40645:
URL: https://github.com/apache/spark/pull/40645#discussion_r1156977007


##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -904,7 +904,10 @@ private[spark] class SparkSubmit extends Logging {
       childArgs ++= Seq("--verbose")
     }
 
-    sparkConf.set("spark.app.submitTime", System.currentTimeMillis().toString)
+    if (!isKubernetesClusterModeDriver) {

Review Comment:
   > Simply setIfMissing？ then it will be set when we first touch it
   
   If user provide conf `spark.app.submitTime`, I think we should overwrite it.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org