You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/07/07 16:53:58 UTC
[GitHub] incubator-brooklyn pull request: Fix failing tests (concurrency pr...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/736
Fix failing tests (concurrency problems and integration tests)
A mix of test fixes
* Lots of concurrency fixes (for unit tests) - it's very easy to bring those out by limiting the process to one CPU and using Windows for it's different thread scheduling behaviour.
* Locale independence - use fixed locale when parsing time values
* Integration test fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/failing-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/736.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #736
----
commit d2d90c273d74f98ed004c54aa82907c468feb86d
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-10T14:21:15Z
Limit number of threads executed in parallel
On a single-CPU machines threads will build up in the queue which leads to OutOfMemoryException (can't allocate enough memory for the stacks). Also a problem on 32 bit VMs.
commit 389acacb6a4fd7374dc4b3df13c0920108472f0c
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-11T11:17:12Z
Increase persistence write limit
Sometimes entities will get another round of writes before the test is able to check the size, going above the previous limit. Usually writes are around 15k, but when this happens they go a bit above 20k.
commit 30e6b4435c813feed48ca5fcadbf49ae6db1baff
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-11T14:43:18Z
Fix test expectations - apps now unmanage themselves on stop.
commit c6bb3b8c0ad2f0f907f8e16b0f316618d5501b3a
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-12T16:51:47Z
Test should wait for feeds to start
Feeds will take some time to start after creation (in this case on rebind). Update the test to handle it.
commit d66df91e4a0276cf47b79d7b417455a70565ba97
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-16T15:09:33Z
Locale independent time parsing
commit 807e6d18b418f660ed17abf3650cbc4a007e9985
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-07-06T14:57:45Z
Convert sanity check exception to an error log - no longer fatal after classpath catalog items use YAML.
Catalog items scanned from the classpath (using reflection and annotations) now
get yaml spec rather than a java type. Can't use those when creating apps from
the legacy app spec format. Fall back to direct classpath loading instead.
commit 160b3ca0fc6fefd9ef5b6e6929c7d3594436cf09
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-07-07T14:24:24Z
Don't try to re-submit DST secondary tasks if already executed
Effectors invoked against an entity will be submitted twice - once in the entity's context and again in the TaskQueueingContext of the caller (see brooklyn.management.internal.LocalManagementContext.runAtEntity(Entity, TaskAdaptable<T>)). Usually it's not a problem because the ExecutionContext will notice it's already submitted and ignore it. But if the entity is unmanaged in the time being then the call to get the entity's ExecutionContext will fail.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix failing tests (concurrency pr...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/736#issuecomment-123338584
Closing, already merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix failing tests (concurrency pr...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/736#issuecomment-121180353
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix failing tests (concurrency pr...
Posted by neykov <gi...@git.apache.org>.
Github user neykov closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---