[GitHub] [maven-war-plugin] pzygielo edited a comment on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

[GitBox <gi...@apache.org>]

pzygielo edited a comment on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639327437


   1. so it seems that (failed) :red_circle: [build 1](https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/pzygielo-mwar-430/1/) ran against 4 commits (it should not matter as contents is the same)
   2. I executed `verify -P run-its` (before push) locally on linux/jdk8 and as on Jenkins - it's ok in my env
   3. on first read of [1/consoleFull](https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/pzygielo-mwar-430/1/consoleFull) failure is not obvious for me.
   I suspected that new class from jakarta
   ```
   $ file WebServlet.class 
   WebServlet.class: compiled Java class data, version 52.0 (Java 1.8)
   ```
   could not collaborate with JDK7.:
   ```
   Caused by: java.lang.UnsupportedClassVersionError: jakarta/servlet/annotation/WebServlet : Unsupported major.minor version 52.0
   ...
       at org.apache.maven.plugins.war.WarMojo.hasClassInClasspath (WarMojo.java:341)
   ```
   but a lot more ITs fail with JDK7, not new one only, so I'm a bit confused...
   
   ---
   <sup>Some ITs fail locally due to no other reason but</sup>
   ```
   Caused by: javax.net.ssl.SSLException: Received fatal alert: protocol_version
   ```
   <sup>for artifacts that are missing in my repository, and maven on JDK7 can't establish connection with central. Setting `-Dhttps.protocols=TLSv1.2` doesn't help, but getting dependency/plugin in other way into repository - does.</sup>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org