[GitHub] willholley opened a new pull request #998: Test duplicate fields in Mango selector

[GitBox <gi...@apache.org>]

willholley opened a new pull request #998: Test duplicate fields in Mango selector
URL: https://github.com/apache/couchdb/pull/998
 
 
   ## Overview
   
   Adds a test to verify the behaviour of duplicate fields in a Mango selector.
   
   The fix for CVE-2017-12635 (#936) resulted in CouchDB's JSON parser only recognising the last instance of duplicated fields in a JSON object. This represents a breaking change to Mango (_find)
   because, previuously, all instances would have been considered when evaluating a selector.
   
   This test verifies that Mango now only considers the last instance of a field, silently ignoring
   those that appear before it.
   
   TBD whether we can or should show an error when this occurs, since this leads to predicates
   silently being ignored.
   
   ## Testing recommendations
   
   Run the Mango test suite.
   
   ## Related Issues or Pull Requests
   
   #936
   
   ## Checklist
   
   - [ ] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services