You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2016/05/12 16:50:18 UTC
[jira] [Updated] (PIG-4880) Overlapping of parameter substitution
names inside&outside a macro fails with NPE
[ https://issues.apache.org/jira/browse/PIG-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Noguchi updated PIG-4880:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 0.16.0
Release Note: Now, macro argument/return names can overlap with parameter substitution names. Former value is taken for these cases.
Status: Resolved (was: Patch Available)
Thanks for the review Daniel! Committed to trunk.
> Overlapping of parameter substitution names inside&outside a macro fails with NPE
> ---------------------------------------------------------------------------------
>
> Key: PIG-4880
> URL: https://issues.apache.org/jira/browse/PIG-4880
> Project: Pig
> Issue Type: Bug
> Components: parser
> Affects Versions: 0.12.0
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Fix For: 0.16.0
>
> Attachments: pig-4880-v01.patch
>
>
> With
> {code:title=macro.pig}
> DEFINE mygroupby(REL, key) RETURNS G {
> %declare number 333;
> $G = GROUP $REL by $key parallel $number;
> };
> {code}
> and
> {code:title=test.pig}
> -- equivalent of -param number=111
> %declare number 111;
> IMPORT 'macro.pig';
> data = LOAD '1234.txt' USING PigStorage() AS (i: int);
> result = mygroupby(data, i);
> STORE result INTO 'test.out' USING PigStorage();
> {code}
> Fails with
> {{error msg: <file myscript.pig, line 4> Macro inline failed for macro 'mygroupby'. Reason: null}}
> Similarly, when macro param and command-line param overlap, it fails with
> {{Macro inline failed for macro 'mygroupby'. Reason: Macro contains argument or return value number which conflicts with a Pig parameter of the same name.}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)