You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/12 18:17:01 UTC

[GitHub] [arrow] assignUser commented on a diff in pull request #13131: ARROW-16402: [R][CI] Create new Archery Tasks

assignUser commented on code in PR #13131:
URL: https://github.com/apache/arrow/pull/13131#discussion_r871680770


##########
ci/docker/centos-7-cpp.dockerfile:
##########
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+FROM centos:centos7
+
+RUN yum install -y \
+        diffutils \
+        gcc-c++ \
+        libcurl-devel \
+        make \
+        openssl-devel \
+        wget \
+        which
+
+# yum install cmake version is too old
+
+ARG cmake=3.18.1

Review Comment:
   I was not sure if there was a reason to pin this version, that's why I did not update it, can do though.
   The ubuntu 18.04 actually uses 3.10.2 as that is what apt has.
   
   Yes I noticed that too, there are several different cmake versions pinned all over the project but I am not familiar enough with possible repercussions/advantages of bumping the version up to make a call on that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org