[GitHub] [zookeeper] eolivelli commented on a change in pull request #1458: ZOOKEEPER-3938: java client: upgrade jline from 2.x to 3.x and adapt Completer to the new API.

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1458:
URL: https://github.com/apache/zookeeper/pull/1458#discussion_r491665871



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java
##########
@@ -282,45 +283,19 @@ public ZooKeeperMain(ZooKeeper zk) {
     void run() throws IOException, InterruptedException {
         if (cl.getCommand() == null) {
             System.out.println("Welcome to ZooKeeper!");
+            System.out.println("JLine support is enabled");

Review comment:
       This line may be noisy. Can we drop it?

##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java
##########
@@ -282,45 +283,19 @@ public ZooKeeperMain(ZooKeeper zk) {
     void run() throws IOException, InterruptedException {
         if (cl.getCommand() == null) {
             System.out.println("Welcome to ZooKeeper!");
+            System.out.println("JLine support is enabled");
 
-            boolean jlinemissing = false;
-            // only use jline if it's in the classpath
-            try {
-                Class<?> consoleC = Class.forName("jline.console.ConsoleReader");

Review comment:
       This part has been dropped.
   So we can't work anymore without jline




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org