You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by tv...@apache.org on 2021/10/05 06:51:20 UTC

[buildstream] 01/05: tests/frontend/show.py: Remove test_planned_order()

This is an automated email from the ASF dual-hosted git repository.

tvb pushed a commit to branch tristan/remove-plan-selection-mode
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 2c6eded82308f36d7ce6e90718bf99b6aa3151a4
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Tue Oct 5 15:22:35 2021 +0900

    tests/frontend/show.py: Remove test_planned_order()
    
    The ability to observe build plan ordering will be removed from `bst show`,
    and the build order (and other orders) is already tested in tests/frontend/order.py.
---
 tests/frontend/show.py | 32 --------------------------------
 1 file changed, 32 deletions(-)

diff --git a/tests/frontend/show.py b/tests/frontend/show.py
index 814e889..3d74bf6 100644
--- a/tests/frontend/show.py
+++ b/tests/frontend/show.py
@@ -4,7 +4,6 @@
 import os
 import sys
 import shutil
-import itertools
 import pytest
 from buildstream.testing import cli  # pylint: disable=unused-import
 from buildstream import _yaml
@@ -213,37 +212,6 @@ def test_show_except(cli, datafiles, targets, exceptions, expected):
         raise AssertionError("Expected elements:\n{}\nInstead received elements:\n{}".format(expected, results))
 
 
-###############################################################
-#                   Testing multiple targets                  #
-###############################################################
-@pytest.mark.datafiles(os.path.join(DATA_DIR, "project"))
-def test_parallel_order(cli, datafiles):
-    project = str(datafiles)
-    elements = ["multiple_targets/order/0.bst", "multiple_targets/order/1.bst"]
-
-    args = ["show", "-d", "plan", "-f", "%{name}", *elements]
-    result = cli.run(project=project, args=args)
-
-    result.assert_success()
-
-    # Get the planned order
-    names = result.output.splitlines()
-    names = [name[len("multiple_targets/order/") :] for name in names]
-
-    # Create all possible 'correct' topological orderings
-    orderings = itertools.product(
-        [("5.bst", "6.bst")],
-        itertools.permutations(["4.bst", "7.bst"]),
-        itertools.permutations(["3.bst", "8.bst"]),
-        itertools.permutations(["2.bst", "9.bst"]),
-        itertools.permutations(["0.bst", "1.bst", "run.bst"]),
-    )
-    orderings = [list(itertools.chain.from_iterable(perm)) for perm in orderings]
-
-    # Ensure that our order is among the correct orderings
-    assert names in orderings, "We got: {}".format(", ".join(names))
-
-
 @pytest.mark.datafiles(os.path.join(DATA_DIR, "project"))
 def test_target_is_dependency(cli, datafiles):
     project = str(datafiles)