You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by yh...@apache.org on 2023/05/23 20:40:13 UTC
[beam] branch master updated: Use default value true for autoSharding if not configured for BigQuery with STORAGE_WRITE_API (#26273)
This is an automated email from the ASF dual-hosted git repository.
yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new dcf0c0f8805 Use default value true for autoSharding if not configured for BigQuery with STORAGE_WRITE_API (#26273)
dcf0c0f8805 is described below
commit dcf0c0f88054e149a34bb39510bdcab0581da982
Author: xianhualiu <12...@users.noreply.github.com>
AuthorDate: Tue May 23 16:40:05 2023 -0400
Use default value true for autoSharding if not configured for BigQuery with STORAGE_WRITE_API (#26273)
* use default value true for autoSharding if not configured for STORAGE_WRITE_API
* use default value true for autoSharding if not configured
* use default value true for autoSharding if not configured for STORAGE_WRITE_API
---
.../org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java | 3 ++-
.../providers/BigQueryStorageWriteApiSchemaTransformProvider.java | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java
index 00b740c7f47..2c9096999c7 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaIOProvider.java
@@ -201,7 +201,8 @@ public class BigQuerySchemaIOProvider implements SchemaIOProvider {
.withWriteDisposition(BigQueryIO.Write.WriteDisposition.WRITE_APPEND);
final Boolean autoSharding = config.getBoolean("autoSharding");
- if (autoSharding != null && autoSharding) {
+ // use default value true for autoSharding if not configured for STORAGE_WRITE_API
+ if (autoSharding == null || autoSharding) {
write = write.withAutoSharding();
}
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
index d9ba400e128..3939e1d9172 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java
@@ -309,8 +309,8 @@ public class BigQueryStorageWriteApiSchemaTransformProvider
(triggeringFrequency == null || triggeringFrequency <= 0)
? DEFAULT_TRIGGERING_FREQUENCY
: Duration.standardSeconds(triggeringFrequency));
-
- if (autoSharding != null && autoSharding) {
+ // use default value true for autoSharding if not configured for STORAGE_WRITE_API
+ if (autoSharding == null || autoSharding) {
write = write.withAutoSharding();
}
}