You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2023/12/30 05:14:48 UTC
[PR] [Draft]fix slick java test [incubator-pekko-connectors]
laglangyue opened a new pull request, #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#issuecomment-1872455871
this pr includes some `clean code`,I will revert later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue closed pull request #301: [Draft]fix slick java test
URL: https://github.com/apache/incubator-pekko-connectors/pull/301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#issuecomment-1872455348
Could you please open CI? There seems to be some issues with using scala objects in `docs.javadsl`
@pjfanning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#discussion_r1438594977
##########
slick/src/test/java/docs/javadsl/DocSnippetFlow.java:
##########
@@ -31,7 +32,7 @@ public static void main(String[] args) throws Exception {
final ActorSystem system = ActorSystem.create();
// #flow-example
- final SlickSession session = SlickSession.forConfig("slick-h2");
+ final SlickSession session = SlickSession$.MODULE$.forConfig("slick-h2");
Review Comment:
GitHub CI only runs automatically for members of the Apache GitHub group. You will have test this stuff on your laptop.
IDEA has lots of issues with compiling Scala. It gets even worse if you want to compile Scala 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#discussion_r1438529197
##########
slick/src/test/java/docs/javadsl/DocSnippetFlow.java:
##########
@@ -31,7 +32,7 @@ public static void main(String[] args) throws Exception {
final ActorSystem system = ActorSystem.create();
// #flow-example
- final SlickSession session = SlickSession.forConfig("slick-h2");
+ final SlickSession session = SlickSession$.MODULE$.forConfig("slick-h2");
Review Comment:
this is not needed and is less readable - I tested that the existing code compiles
```
sbt slick/test
```
I deliberately changed the Java code to add an unexpected character and the sbt command above failed - meaning that that command does compile the Java tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#discussion_r1438593455
##########
slick/src/test/java/docs/javadsl/DocSnippetFlow.java:
##########
@@ -31,7 +32,7 @@ public static void main(String[] args) throws Exception {
final ActorSystem system = ActorSystem.create();
// #flow-example
- final SlickSession session = SlickSession.forConfig("slick-h2");
+ final SlickSession session = SlickSession$.MODULE$.forConfig("slick-h2");
Review Comment:
My idea will report an error.
It maybe a bug for idea.In fact, I also test passed locally, then I wan to know how ci work with it, so I open this PR,because of lacking of github action.
I will report this for idea-scala-plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#issuecomment-1872483053
I would prefer not to run this. You can experiment on your own fork. Or you can test on your laptop.
To test on your fork, enable CI in setup. And you can modify the workflow yml to remove the condition that enforces that the workflow only runs for the Apache fork of this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#discussion_r1438594977
##########
slick/src/test/java/docs/javadsl/DocSnippetFlow.java:
##########
@@ -31,7 +32,7 @@ public static void main(String[] args) throws Exception {
final ActorSystem system = ActorSystem.create();
// #flow-example
- final SlickSession session = SlickSession.forConfig("slick-h2");
+ final SlickSession session = SlickSession$.MODULE$.forConfig("slick-h2");
Review Comment:
GitHub CI only runs automatically for members of the Apache GitHub group. You will have to test this stuff on your laptop.
IDEA has lots of issues with compiling Scala. It gets even worse if you want to compile Scala 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#discussion_r1438594530
##########
slick/src/test/java/docs/javadsl/DocSnippetFlow.java:
##########
@@ -31,7 +32,7 @@ public static void main(String[] args) throws Exception {
final ActorSystem system = ActorSystem.create();
// #flow-example
- final SlickSession session = SlickSession.forConfig("slick-h2");
+ final SlickSession session = SlickSession$.MODULE$.forConfig("slick-h2");
Review Comment:
I understand it,it truely a bug for idea, because the bytecode is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#discussion_r1438604146
##########
slick/src/test/java/docs/javadsl/DocSnippetFlow.java:
##########
@@ -31,7 +32,7 @@ public static void main(String[] args) throws Exception {
final ActorSystem system = ActorSystem.create();
// #flow-example
- final SlickSession session = SlickSession.forConfig("slick-h2");
+ final SlickSession session = SlickSession$.MODULE$.forConfig("slick-h2");
Review Comment:
```scala
class TestObject
class TestHello {
def hello() = {
println("ok")
}
}
object TestObject extends TestHello
```
I write a min code of this.
Idea will not prompt methods of object which is extended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [Draft]fix slick java test [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #301:
URL: https://github.com/apache/incubator-pekko-connectors/pull/301#issuecomment-1872483571
I will not merge any PRs that do not fully explain the reason for the changed. Todo is not an acceptable description. I have no idea why the changed in this PR are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org