[GitHub] [pinot] walterddr commented on a diff in pull request #11103: Improve error message in case of throwables in multistage

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #11103:
URL: https://github.com/apache/pinot/pull/11103#discussion_r1264255147


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -218,9 +218,9 @@ private BrokerResponse handleRequest(long requestId, String query, @Nullable Sql
       queryResults = _queryDispatcher.submitAndReduce(requestId, dispatchableSubPlan, _mailboxService,
           _reducerScheduler,
           queryTimeoutMs, sqlNodeAndOptions.getOptions(), stageIdStatsMap, traceEnabled);
-    } catch (Exception e) {
-      LOGGER.info("query execution failed", e);
-      return new BrokerResponseNative(QueryException.getException(QueryException.QUERY_EXECUTION_ERROR, e));
+    } catch (Throwable t) {
+      LOGGER.error("query execution failed: " + t);

Review Comment:
   ```suggestion
         LOGGER.error("query execution failed", t);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org