You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/04/05 15:43:10 UTC
Review Request 45740: RANGER-910 : Improve db and java patches
execution logic to make that more robust
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45740/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-910
https://issues.apache.org/jira/browse/RANGER-910
Repository: ranger
Description
-------
**Problem Statement:** Ranger installation process should not allow concurrent execution of DB or java patches as concurrent execution of patches can lead to inconsistent state of data and application.
**Proposed Solution :** Before executing db or java patch; installation process will insert patch status in x_db_version_h table with active='N' value, If patch will get executed successfully then status of patch will be set to 'Y'; otherwise patch status row from x_db_version_h will be deleted. If patch is being executed then active column will have value 'N' and no other process will be allowed to execute that patch.
Diffs
-----
security-admin/scripts/db_setup.py f2cc9b9
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java c4a823c
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 3e5b30b
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e9c8394
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 5cb0290
Diff: https://reviews.apache.org/r/45740/diff/
Testing
-------
Steps Performed (With Patch) :
After configuring values in install.properties file, called setup.sh from different terminals.
Result Behaviour :
Ranger Was installed successfully and was able to login in Ranger Admin UI.
Note: Patch has been tested for all DB flavors.
Thanks,
Pradeep Agrawal
Re: Review Request 45740: RANGER-910 : Improve db and java patches
execution logic to make that more robust
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45740/#review127469
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 6, 2016, 6:09 a.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45740/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 6:09 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-910
> https://issues.apache.org/jira/browse/RANGER-910
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement:** Ranger installation process should not allow concurrent execution of DB or java patches as concurrent execution of patches can lead to inconsistent state of data and application.
>
> **Proposed Solution :** Before executing db or java patch; installation process will insert patch status in x_db_version_h table with active='N' value, If patch will get executed successfully then status of patch will be set to 'Y'; otherwise patch status row from x_db_version_h will be deleted. If patch is being executed then active column will have value 'N' and no other process will be allowed to execute that patch.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java f231b09
> security-admin/scripts/db_setup.py f2cc9b9
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a8f063b
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 3e5b30b
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 6f53a24
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 17da9be
>
> Diff: https://reviews.apache.org/r/45740/diff/
>
>
> Testing
> -------
>
> Steps Performed (With Patch) :
>
> After configuring values in install.properties file, called setup.sh from different terminals.
>
> Result Behaviour :
> Ranger Was installed successfully and was able to login in Ranger Admin UI.
>
> Note: Patch has been tested for all DB flavors.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>
Re: Review Request 45740: RANGER-910 : Improve db and java patches
execution logic to make that more robust
Posted by Pradeep Agrawal <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45740/
-----------------------------------------------------------
(Updated April 6, 2016, 6:09 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Updated diff based on latest commit to avoid conflicts.
Bugs: RANGER-910
https://issues.apache.org/jira/browse/RANGER-910
Repository: ranger
Description
-------
**Problem Statement:** Ranger installation process should not allow concurrent execution of DB or java patches as concurrent execution of patches can lead to inconsistent state of data and application.
**Proposed Solution :** Before executing db or java patch; installation process will insert patch status in x_db_version_h table with active='N' value, If patch will get executed successfully then status of patch will be set to 'Y'; otherwise patch status row from x_db_version_h will be deleted. If patch is being executed then active column will have value 'N' and no other process will be allowed to execute that patch.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java f231b09
security-admin/scripts/db_setup.py f2cc9b9
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java a8f063b
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 3e5b30b
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 6f53a24
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 17da9be
Diff: https://reviews.apache.org/r/45740/diff/
Testing
-------
Steps Performed (With Patch) :
After configuring values in install.properties file, called setup.sh from different terminals.
Result Behaviour :
Ranger Was installed successfully and was able to login in Ranger Admin UI.
Note: Patch has been tested for all DB flavors.
Thanks,
Pradeep Agrawal