You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/11/15 08:22:34 UTC
[GitHub] [commons-lang] arturobernalg opened a new pull request #651: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN
arturobernalg opened a new pull request #651:
URL: https://github.com/apache/commons-lang/pull/651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on pull request #651: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #651:
URL: https://github.com/apache/commons-lang/pull/651#issuecomment-727629215
Rebase on master, and fix checkstyle problems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on a change in pull request #651: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #651:
URL: https://github.com/apache/commons-lang/pull/651#discussion_r523784572
##########
File path: src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
##########
@@ -309,6 +309,14 @@ public void testContainsFloat() {
assertFalse(ArrayUtils.contains(array, (float) 99));
}
+ @Test
+ public void testContainsFloatNaN() {
+ float[] a = new float[] { Float.NEGATIVE_INFINITY, Float.NaN, Float.POSITIVE_INFINITY };
Review comment:
a -> array
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #651: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #651:
URL: https://github.com/apache/commons-lang/pull/651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #651: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #651:
URL: https://github.com/apache/commons-lang/pull/651#issuecomment-727612354
@arturobernalg please rebase on master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] arturobernalg commented on a change in pull request #651: [LANG-1615] - ArrayUtils contains && indexOf fails to handle Float.NaN
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #651:
URL: https://github.com/apache/commons-lang/pull/651#discussion_r523785816
##########
File path: src/test/java/org/apache/commons/lang3/ArrayUtilsTest.java
##########
@@ -309,6 +309,14 @@ public void testContainsFloat() {
assertFalse(ArrayUtils.contains(array, (float) 99));
}
+ @Test
+ public void testContainsFloatNaN() {
+ float[] a = new float[] { Float.NEGATIVE_INFINITY, Float.NaN, Float.POSITIVE_INFINITY };
Review comment:
Changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org