You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2016/05/26 17:23:59 UTC
Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
Diff: https://reviews.apache.org/r/47908/diff/
Testing
-------
Thanks,
Jianxia Chen
Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135021
-----------------------------------------------------------
I don't understand from your description how this fixes the problem. Maybe a more complete description of the problem would help.
- Bruce Schuchardt
On May 26, 2016, 5:23 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 5:23 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
>
> Diff: https://reviews.apache.org/r/47908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135020
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java (line 86)
<https://reviews.apache.org/r/47908/#comment200008>
You should get rid of "synchronized" on the methods.
Others look good.
Fit it and ship it.
- xiaojian zhou
On May 26, 2016, 5:23 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 5:23 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
>
> Diff: https://reviews.apache.org/r/47908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135083
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On May 26, 2016, 8:34 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 8:34 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 62336f0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
>
> Diff: https://reviews.apache.org/r/47908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135067
-----------------------------------------------------------
Ship it!
It looks good.
Just one qestion, do we need to check if haContainer == null in HARegionQueue.java?
- xiaojian zhou
On May 26, 2016, 8:34 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 8:34 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 62336f0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
>
> Diff: https://reviews.apache.org/r/47908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/#review135740
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On May 26, 2016, 8:34 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47908/
> -----------------------------------------------------------
>
> (Updated May 26, 2016, 8:34 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 62336f0
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
>
> Diff: https://reviews.apache.org/r/47908/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in
com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47908/
-----------------------------------------------------------
(Updated May 26, 2016, 8:34 p.m.)
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Udo Kohlmeyer, Dan Smith, and xiaojian zhou.
Changes
-------
Instead of using lock to synchronize access to ccnSingleton, make haContainer volatile.
Repository: geode
Description
-------
Add a lock to synchronize two getInstance methods, so that they return either null ccnSingleton or fully initialized ccnSingleton, i.e. haContainer is not null if it is not gateway receiver.
Diffs (updated)
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 62336f0
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java 80d05ba
Diff: https://reviews.apache.org/r/47908/diff/
Testing
-------
Thanks,
Jianxia Chen