You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "Maxim Khutornenko (JIRA)" <ji...@apache.org> on 2015/10/08 22:29:26 UTC
[jira] [Created] (AURORA-1517) Decide on TaskConfig diff library
for the getJobUpdateDiff API
Maxim Khutornenko created AURORA-1517:
-----------------------------------------
Summary: Decide on TaskConfig diff library for the getJobUpdateDiff API
Key: AURORA-1517
URL: https://issues.apache.org/jira/browse/AURORA-1517
Project: Aurora
Issue Type: Task
Components: Scheduler
Reporter: Maxim Khutornenko
Need a JSON diff library to compare TaskConfig instances. See design doc for more details: https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Created] (AURORA-1517) Decide on TaskConfig diff library
for the getJobUpdateDiff API
Posted by Bill Farner <wf...@apache.org>.
I am concerned about the internal complexity (choosing a diff algorithm,
testing), the API-level complexity (structure and encoding of the diff
result), and I am also skeptical that it is sufficiently common that it
warrants inclusion (YAGNI).
I say let API clients (who might know more to make sense out of the
ExecutorConfig anyway) do this for now.
On Thursday, October 8, 2015, Maxim Khutornenko <ma...@apache.org> wrote:
> Can you elaborate why? Are you concerned about the implied complexity
> or anything else?
>
> On Thu, Oct 8, 2015 at 2:09 PM, Bill Farner <wfarner@apache.org
> <javascript:;>> wrote:
> > I do indeed think the scheduler should not be doing this type of diff
> > operation, and it should be up to an API consumer.
> >
> > On Thursday, October 8, 2015, Maxim Khutornenko <maxim@apache.org
> <javascript:;>> wrote:
> >
> >> This isn't about JSON in the context of ExecutorConfig. The ticket
> >> assumes converting the entire TaskConfigs into JSON and then comparing
> >> them with the help of JSON diff library. I should have made it clear.
> >>
> >> Does this answer your concern or do you think we should not provide
> >> TaskConfig diff details at all?
> >>
> >> On Thu, Oct 8, 2015 at 1:59 PM, Bill Farner <wfarner@apache.org
> <javascript:;>
> >> <javascript:;>> wrote:
> >> > I thought JSON diffing was scrapped? I really don't think we should
> do
> >> > this.
> >> >
> >> > On Thursday, October 8, 2015, Maxim Khutornenko (JIRA) <
> jira@apache.org <javascript:;>
> >> <javascript:;>>
> >> > wrote:
> >> >
> >> >> Maxim Khutornenko created AURORA-1517:
> >> >> -----------------------------------------
> >> >>
> >> >> Summary: Decide on TaskConfig diff library for the
> >> >> getJobUpdateDiff API
> >> >> Key: AURORA-1517
> >> >> URL:
> https://issues.apache.org/jira/browse/AURORA-1517
> >> >> Project: Aurora
> >> >> Issue Type: Task
> >> >> Components: Scheduler
> >> >> Reporter: Maxim Khutornenko
> >> >>
> >> >>
> >> >> Need a JSON diff library to compare TaskConfig instances. See design
> doc
> >> >> for more details:
> >> >>
> >>
> https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> This message was sent by Atlassian JIRA
> >> >> (v6.3.4#6332)
> >> >>
> >>
>
Re: [jira] [Created] (AURORA-1517) Decide on TaskConfig diff library
for the getJobUpdateDiff API
Posted by Maxim Khutornenko <ma...@apache.org>.
Can you elaborate why? Are you concerned about the implied complexity
or anything else?
On Thu, Oct 8, 2015 at 2:09 PM, Bill Farner <wf...@apache.org> wrote:
> I do indeed think the scheduler should not be doing this type of diff
> operation, and it should be up to an API consumer.
>
> On Thursday, October 8, 2015, Maxim Khutornenko <ma...@apache.org> wrote:
>
>> This isn't about JSON in the context of ExecutorConfig. The ticket
>> assumes converting the entire TaskConfigs into JSON and then comparing
>> them with the help of JSON diff library. I should have made it clear.
>>
>> Does this answer your concern or do you think we should not provide
>> TaskConfig diff details at all?
>>
>> On Thu, Oct 8, 2015 at 1:59 PM, Bill Farner <wfarner@apache.org
>> <javascript:;>> wrote:
>> > I thought JSON diffing was scrapped? I really don't think we should do
>> > this.
>> >
>> > On Thursday, October 8, 2015, Maxim Khutornenko (JIRA) <jira@apache.org
>> <javascript:;>>
>> > wrote:
>> >
>> >> Maxim Khutornenko created AURORA-1517:
>> >> -----------------------------------------
>> >>
>> >> Summary: Decide on TaskConfig diff library for the
>> >> getJobUpdateDiff API
>> >> Key: AURORA-1517
>> >> URL: https://issues.apache.org/jira/browse/AURORA-1517
>> >> Project: Aurora
>> >> Issue Type: Task
>> >> Components: Scheduler
>> >> Reporter: Maxim Khutornenko
>> >>
>> >>
>> >> Need a JSON diff library to compare TaskConfig instances. See design doc
>> >> for more details:
>> >>
>> https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8
>> >>
>> >>
>> >>
>> >> --
>> >> This message was sent by Atlassian JIRA
>> >> (v6.3.4#6332)
>> >>
>>
Re: [jira] [Created] (AURORA-1517) Decide on TaskConfig diff library
for the getJobUpdateDiff API
Posted by Bill Farner <wf...@apache.org>.
I do indeed think the scheduler should not be doing this type of diff
operation, and it should be up to an API consumer.
On Thursday, October 8, 2015, Maxim Khutornenko <ma...@apache.org> wrote:
> This isn't about JSON in the context of ExecutorConfig. The ticket
> assumes converting the entire TaskConfigs into JSON and then comparing
> them with the help of JSON diff library. I should have made it clear.
>
> Does this answer your concern or do you think we should not provide
> TaskConfig diff details at all?
>
> On Thu, Oct 8, 2015 at 1:59 PM, Bill Farner <wfarner@apache.org
> <javascript:;>> wrote:
> > I thought JSON diffing was scrapped? I really don't think we should do
> > this.
> >
> > On Thursday, October 8, 2015, Maxim Khutornenko (JIRA) <jira@apache.org
> <javascript:;>>
> > wrote:
> >
> >> Maxim Khutornenko created AURORA-1517:
> >> -----------------------------------------
> >>
> >> Summary: Decide on TaskConfig diff library for the
> >> getJobUpdateDiff API
> >> Key: AURORA-1517
> >> URL: https://issues.apache.org/jira/browse/AURORA-1517
> >> Project: Aurora
> >> Issue Type: Task
> >> Components: Scheduler
> >> Reporter: Maxim Khutornenko
> >>
> >>
> >> Need a JSON diff library to compare TaskConfig instances. See design doc
> >> for more details:
> >>
> https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8
> >>
> >>
> >>
> >> --
> >> This message was sent by Atlassian JIRA
> >> (v6.3.4#6332)
> >>
>
Re: [jira] [Created] (AURORA-1517) Decide on TaskConfig diff library
for the getJobUpdateDiff API
Posted by Maxim Khutornenko <ma...@apache.org>.
This isn't about JSON in the context of ExecutorConfig. The ticket
assumes converting the entire TaskConfigs into JSON and then comparing
them with the help of JSON diff library. I should have made it clear.
Does this answer your concern or do you think we should not provide
TaskConfig diff details at all?
On Thu, Oct 8, 2015 at 1:59 PM, Bill Farner <wf...@apache.org> wrote:
> I thought JSON diffing was scrapped? I really don't think we should do
> this.
>
> On Thursday, October 8, 2015, Maxim Khutornenko (JIRA) <ji...@apache.org>
> wrote:
>
>> Maxim Khutornenko created AURORA-1517:
>> -----------------------------------------
>>
>> Summary: Decide on TaskConfig diff library for the
>> getJobUpdateDiff API
>> Key: AURORA-1517
>> URL: https://issues.apache.org/jira/browse/AURORA-1517
>> Project: Aurora
>> Issue Type: Task
>> Components: Scheduler
>> Reporter: Maxim Khutornenko
>>
>>
>> Need a JSON diff library to compare TaskConfig instances. See design doc
>> for more details:
>> https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
Re: [jira] [Created] (AURORA-1517) Decide on TaskConfig diff library
for the getJobUpdateDiff API
Posted by Bill Farner <wf...@apache.org>.
I thought JSON diffing was scrapped? I really don't think we should do
this.
On Thursday, October 8, 2015, Maxim Khutornenko (JIRA) <ji...@apache.org>
wrote:
> Maxim Khutornenko created AURORA-1517:
> -----------------------------------------
>
> Summary: Decide on TaskConfig diff library for the
> getJobUpdateDiff API
> Key: AURORA-1517
> URL: https://issues.apache.org/jira/browse/AURORA-1517
> Project: Aurora
> Issue Type: Task
> Components: Scheduler
> Reporter: Maxim Khutornenko
>
>
> Need a JSON diff library to compare TaskConfig instances. See design doc
> for more details:
> https://docs.google.com/document/d/1Fc_YhhV7fc4D9Xv6gJzpfooxbK4YWZcvzw6Bd3qVTL8
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>