You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/21 12:55:27 UTC
[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #169: Move config docs to /reference and improve docs gen scripts
SignorMercurio opened a new pull request, #169:
URL: https://github.com/apache/pulsar-site/pull/169
@urfreespace PTAL carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace merged pull request #169: Move config docs to /reference and improve docs gen scripts
Posted by GitBox <gi...@apache.org>.
urfreespace merged PR #169:
URL: https://github.com/apache/pulsar-site/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] SignorMercurio commented on pull request #169: Move config docs to /reference and improve docs gen scripts
Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on PR #169:
URL: https://github.com/apache/pulsar-site/pull/169#issuecomment-1224081761
@urfreespace I tested the commands in the scripts manually, which works fine now. Not sure if `build-site.sh` works fine in Actions, can we temporary modify the workflow to run it on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] urfreespace commented on a diff in pull request #169: Move config docs to /reference and improve docs gen scripts
Posted by GitBox <gi...@apache.org>.
urfreespace commented on code in PR #169:
URL: https://github.com/apache/pulsar-site/pull/169#discussion_r952038848
##########
site2/tools/build-site.sh:
##########
@@ -22,10 +22,12 @@ ROOT_DIR=$(git rev-parse --show-toplevel)
VERSION=$(${ROOT_DIR}/src/get-project-version.py)
NEXT=$1
-WEBSITE_DIR="website"
+WEBSITE_DIR=${ROOT_DIR}/site2/website
if [ -n "$NEXT" ]; then
- WEBSITE_DIR="website-"$NEXT
+ WEBSITE_DIR=${ROOT_DIR}/site2/website-$NEXT
fi
+TOOLS_DIR=${ROOT_DIR}/site2/tools
+GEN_SITE_DIR=$GEN_SITE_DIR
Review Comment:
why `GEN_SITE_DIR=$GEN_SITE_DIR`? Is this redundant? @SignorMercurio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] SignorMercurio commented on a diff in pull request #169: Move config docs to /reference and improve docs gen scripts
Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on code in PR #169:
URL: https://github.com/apache/pulsar-site/pull/169#discussion_r952042410
##########
site2/tools/build-site.sh:
##########
@@ -22,10 +22,12 @@ ROOT_DIR=$(git rev-parse --show-toplevel)
VERSION=$(${ROOT_DIR}/src/get-project-version.py)
NEXT=$1
-WEBSITE_DIR="website"
+WEBSITE_DIR=${ROOT_DIR}/site2/website
if [ -n "$NEXT" ]; then
- WEBSITE_DIR="website-"$NEXT
+ WEBSITE_DIR=${ROOT_DIR}/site2/website-$NEXT
fi
+TOOLS_DIR=${ROOT_DIR}/site2/tools
+GEN_SITE_DIR=$GEN_SITE_DIR
Review Comment:
This is a mistake. I'll fix it and try to test it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org