You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by katya-stoycheva <gi...@git.apache.org> on 2017/07/11 14:40:05 UTC
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
GitHub user katya-stoycheva opened a pull request:
https://github.com/apache/tomcat/pull/69
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61232
Checks for one char separator only, not specifically for "."
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/katya-stoycheva/tomcat trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Posted by katya-stoycheva <gi...@git.apache.org>.
Github user katya-stoycheva commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/69#discussion_r126873704
--- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java ---
@@ -0,0 +1,59 @@
+package org.apache.juli;
+
+import static org.junit.Assert.assertTrue;
+
+import java.io.File;
+
+import org.apache.catalina.startup.LoggingBaseTest;
+import org.junit.After;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class TestFileHandlerNonRotatable extends LoggingBaseTest {
+ private FileHandler testHandler;
+
+ @BeforeClass
+ public static void setUpPerTestClass() throws Exception {
+ System.setProperty("java.util.logging.manager",
+ "org.apache.juli.ClassLoaderLogManager");
+ System.setProperty("java.util.logging.config.file",
+ TestFileHandlerNonRotatable.class
+ .getResource("logging-non-rotatable.properties")
+ .getFile());
+ }
--- End diff --
added a line to decode URL path but this behavior is different in IDE (Eclipse in my case) and command line so please test both to be sure everything works
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Posted by katya-stoycheva <gi...@git.apache.org>.
Github user katya-stoycheva commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/69#discussion_r126873614
--- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java ---
@@ -0,0 +1,59 @@
+package org.apache.juli;
--- End diff --
Added
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Posted by violetagg <gi...@git.apache.org>.
Github user violetagg commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/69#discussion_r126773883
--- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java ---
@@ -0,0 +1,59 @@
+package org.apache.juli;
--- End diff --
Please add copyright header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request #69: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=...
Posted by violetagg <gi...@git.apache.org>.
Github user violetagg commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/69#discussion_r126779410
--- Diff: test/org/apache/juli/TestFileHandlerNonRotatable.java ---
@@ -0,0 +1,59 @@
+package org.apache.juli;
+
+import static org.junit.Assert.assertTrue;
+
+import java.io.File;
+
+import org.apache.catalina.startup.LoggingBaseTest;
+import org.junit.After;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class TestFileHandlerNonRotatable extends LoggingBaseTest {
+ private FileHandler testHandler;
+
+ @BeforeClass
+ public static void setUpPerTestClass() throws Exception {
+ System.setProperty("java.util.logging.manager",
+ "org.apache.juli.ClassLoaderLogManager");
+ System.setProperty("java.util.logging.config.file",
+ TestFileHandlerNonRotatable.class
+ .getResource("logging-non-rotatable.properties")
+ .getFile());
+ }
--- End diff --
This is not working on my system as I have **space** in the path:
```
java.io.FileNotFoundException: /.../tc9.0.x%20(trunk)/.../org/apache/juli/logging-non-rotatable.properties (No such file or directory)
at java.io.FileInputStream.open0(Native Method)
at java.io.FileInputStream.open(FileInputStream.java:195)
at java.io.FileInputStream.<init>(FileInputStream.java:138)
at java.io.FileInputStream.<init>(FileInputStream.java:93)
at org.apache.juli.ClassLoaderLogManager.readConfiguration(ClassLoaderLogManager.java:469)
at org.apache.juli.ClassLoaderLogManager.readConfiguration(ClassLoaderLogManager.java:309)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org