You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wilmerdooley (via GitHub)" <gi...@apache.org> on 2026/06/19 07:07:47 UTC
[PR] FLINK-39586: Mark the combined watermark status idle when all partial watermarks are unregistered [flink]
wilmerdooley opened a new pull request, #28486:
URL: https://github.com/apache/flink/pull/28486
This change updates flink-core/src/main/java/org/apache/flink/api/common/eventtime/CombinedWatermarkStatus.java, flink-core/src/test/java/org/apache/flink/api/common/eventtime/CombinedWatermarkStatusTest.java, flink-core/src/test/java/org/apache/flink/api/common/eventtime/WatermarkOutputMultiplexerTest.java.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
JIRA: https://issues.apache.org/jira/browse/FLINK-39586
Generated-by: Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39586][core] Mark the combined watermark status idle when all partial watermarks are unregistered [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28486:
URL: https://github.com/apache/flink/pull/28486#issuecomment-4753943353
Looping in @AHeise @fapaul for comments on the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39586][core] Mark the combined watermark status idle when all partial watermarks are unregistered [flink]
Posted by "wilmerdooley (via GitHub)" <gi...@apache.org>.
wilmerdooley commented on PR #28486:
URL: https://github.com/apache/flink/pull/28486#issuecomment-4753905495
I have run spotless:apply and pushed it, so the format check should be sorted.
On FLINK-23767 (#16817, FLIP-180): it removed this line on purpose. FLIP-180 makes idleness user-controlled and drops the code that auto-marks a source idle, to avoid late records, so re-adding it reintroduces exactly the automatic idleness it set out to remove. I agree it should not go back as a blind revert.
That said, the empty/all-unregistered case still looks like a real gap (FLINK-38454 deliberately left this branch alone). FLIP-180 and FLINK-38454 both handle "inputs gone" by flushing the maximum watermark rather than signalling idle, so emitting the combined max watermark when the outputs drain to empty would fit the current model better than toggling the idle flag.
Would you prefer that direction, or to handle it closer to StatusWatermarkValve / the idleness path? Happy to follow your call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39586][core] Mark the combined watermark status idle when all partial watermarks are unregistered [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28486:
URL: https://github.com/apache/flink/pull/28486#issuecomment-4749324041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77e76ffa7da8c1e664053bc83b87fedfcfb8f205",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77e76ffa7da8c1e664053bc83b87fedfcfb8f205",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77e76ffa7da8c1e664053bc83b87fedfcfb8f205 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org