You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/10/26 11:50:24 UTC
[GitHub] [incubator-hugegraph-computer] imbajin opened a new pull request, #189: chore: update a string of ci configs & gitignore & REAME
imbajin opened a new pull request, #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189
also fix typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #189: chore: update a string of ci configs & gitignore & REAME
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189#discussion_r1005837965
##########
.github/workflows/ci.yml:
##########
@@ -5,14 +5,8 @@ on:
branches:
- master
- /^release-.*$/
- - /^test-.*$/
- /^v[0-9]\..*$/
pull_request:
- branches:
Review Comment:
yes
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -7,7 +7,7 @@ on:
branches: [ master, release-*, v0.* ]
pull_request:
# The branches below must be a subset of the branches above
- branches: [ master ]
+ # branches: [ master ] # enable it in all PR
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on a diff in pull request #189: chore: update a string of ci configs & gitignore & REAME
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189#discussion_r1010222052
##########
.github/workflows/publish_images.yml:
##########
@@ -1,5 +1,6 @@
name: publish hugegraph-computer images
+# TODO: could we use this action now? (if not, what shall we do?)
on:
Review Comment:
we couldn't use it due to lack (apache) permission, so just disable it manually (consider someway to use it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] codecov[bot] commented on pull request #189: chore: update a string of ci configs & gitignore & REAME
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189#issuecomment-1291931528
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#189](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/189?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f7cd30) into [master](https://codecov.io/gh/apache/incubator-hugegraph-computer/commit/180051786606fe7c93fcee66f66c50a6864072bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1800517) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #189 +/- ##
============================================
- Coverage 86.12% 86.10% -0.02%
+ Complexity 3212 3210 -2
============================================
Files 341 341
Lines 12200 12200
Branches 1085 1085
============================================
- Hits 10507 10505 -2
Misses 1171 1171
- Partials 522 524 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hugegraph/computer/core/network/TransportUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-computer/pull/189/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tcHV0ZXItY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvY29tcHV0ZXIvY29yZS9uZXR3b3JrL1RyYW5zcG9ydFV0aWwuamF2YQ==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] javeme commented on a diff in pull request #189: chore: update a string of ci configs & gitignore & REAME
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189#discussion_r1005812038
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -7,7 +7,7 @@ on:
branches: [ master, release-*, v0.* ]
pull_request:
# The branches below must be a subset of the branches above
- branches: [ master ]
+ # branches: [ master ] # enable it in all PR
Review Comment:
branches=empty means any pr? if so please update the comment at line 9
##########
.github/workflows/ci.yml:
##########
@@ -5,14 +5,8 @@ on:
branches:
- master
- /^release-.*$/
- - /^test-.*$/
- /^v[0-9]\..*$/
pull_request:
- branches:
Review Comment:
means any branch if keep none?
##########
README.md:
##########
@@ -5,19 +5,31 @@
[](https://codecov.io/gh/hugegraph/hugegraph-computer)
[](https://hub.docker.com/repository/docker/hugegraph/hugegraph-builtin-algorithms)
-hugegraph-computer is a distributed graph processing system for hugegraph. It is an implementaion of [Pregel](https://kowshik.github.io/JPregel/pregel_paper.pdf). It runs on Kubernetes or YARN framework.
+hugegraph-computer is a distributed graph processing system for hugegraph. It is an implementation of [Pregel](https://kowshik.github.io/JPregel/pregel_paper.pdf). It runs on Kubernetes or YARN framework.
## Features
- Based on BSP(Bulk Synchronous Parallel) model, every iteration is a superstep.
-- Auto memory management. The framework will spilt some data to disk, the framework will never OOM(Out of Memory).
-- The the part of edges or the messages of super node can be in memory, so you will never loss it.
+- Auto memory management. The framework will split some data to disk, the framework will never OOM(Out of Memory).
+- The part of edges or the messages of super node can be in memory, so you will never lose it.
- You can output the result to HDFS or HugeGraph, or any other system.
-- Easy to develop a new algotirhm. You need to focus on a vertex only, not to worry about messages transfering and memory.
+- Easy to develop a new algorithm. You need to focus on a vertex only, not to worry about messages transferring and memory.
## Learn More
-The [project homepage](https://hugegraph.github.io/hugegraph-doc/) contains more information about hugegraph-computer.
+The [project homepage](https://hugegraph.apache.org/docs/) contains more information about hugegraph-computer.
+
+And here are links of other repositories:
+1. [hugegraph-server](https://github.com/apache/incubator-hugegraph) (graph's core component - OLTP server)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin merged pull request #189: chore: update a string of ci configs & gitignore & README
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-computer] imbajin commented on pull request #189: chore: update a string of ci configs & gitignore & REAME
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #189:
URL: https://github.com/apache/incubator-hugegraph-computer/pull/189#issuecomment-1298227209
@coderzc after this PR merged, travis CI will disappear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org