You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/18 10:56:40 UTC

[GitHub] [hadoop] sodonnel opened a new pull request #984: HDDS-1674 Make ScmBlockLocationProtocol message type based

sodonnel opened a new pull request #984: HDDS-1674 Make ScmBlockLocationProtocol message type based
URL: https://github.com/apache/hadoop/pull/984
 
 
   This PR is a first attempt at refactoring the ScmBlockLocationProtocol using a single message type as is used in the OzoneManagerProtocol. In this change, the new message wraps the existing messages and the translator classes simply wrap or unwrap it.
   
   Only TraceID has been moved to the wrapper message - Moving error handling and error codes to the wrapper will be done in a separate change.
   
   Before this can be merged we still need to determine if the clientId should be present in the  ScmBlockLocationProtocol. It is in OzoneManagerProtocol and has been replicated here for now, but it can be removed if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org