You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "eldenmoon (via GitHub)" <gi...@apache.org> on 2024/06/13 13:37:07 UTC
[PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
eldenmoon opened a new pull request, #36277:
URL: https://github.com/apache/doris/pull/36277
…path in executing match expressions
The correct column name should be like `CAST value.name(Nullable(Variant)) TO Nullable(String)` since the predicate is `cast(value['name'] as string) match 'xxx'`
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #36277:
URL: https://github.com/apache/doris/pull/36277#discussion_r1639419165
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2692,13 +2715,16 @@ void SegmentIterator::_calculate_pred_in_remaining_conjunct_root(
auto node_type = expr->node_type();
if (node_type == TExprNodeType::SLOT_REF) {
+ auto slot_expr = std::dynamic_pointer_cast<doris::vectorized::VSlotRef>(expr);
Review Comment:
need if (slot_expr != nullptr) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165966468
<details>
<summary>ClickBench: <b>Total hot run time: 30.15 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5f493df0bfffb57bea05e144dbc79b37e57c2f5, data reload: false
query1 0.04 0.04 0.02
query2 0.08 0.04 0.04
query3 0.24 0.05 0.05
query4 1.68 0.07 0.07
query5 0.50 0.49 0.49
query6 1.13 0.72 0.73
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.55 0.48 0.49
query10 0.55 0.56 0.54
query11 0.15 0.11 0.11
query12 0.15 0.12 0.12
query13 0.60 0.59 0.61
query14 0.77 0.77 0.78
query15 0.82 0.81 0.82
query16 0.37 0.37 0.37
query17 1.05 1.06 1.05
query18 0.24 0.23 0.25
query19 1.80 1.81 1.78
query20 0.02 0.01 0.01
query21 15.42 0.65 0.66
query22 4.63 7.50 1.50
query23 18.25 1.46 1.24
query24 2.09 0.22 0.21
query25 0.17 0.09 0.08
query26 0.26 0.17 0.17
query27 0.10 0.08 0.08
query28 13.27 1.01 1.00
query29 12.58 3.26 3.27
query30 0.27 0.06 0.05
query31 2.85 0.38 0.39
query32 3.28 0.47 0.48
query33 2.87 2.95 2.90
query34 17.18 4.36 4.49
query35 4.46 4.45 4.52
query36 0.66 0.45 0.46
query37 0.19 0.15 0.15
query38 0.15 0.15 0.15
query39 0.05 0.03 0.04
query40 0.17 0.16 0.14
query41 0.09 0.05 0.05
query42 0.06 0.05 0.04
query43 0.05 0.04 0.03
Total cold run time: 109.91 s
Total hot run time: 30.15 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165883895
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165701323
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165918108
<details>
<summary>TPC-H: <b>Total hot run time: 39699 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e5f493df0bfffb57bea05e144dbc79b37e57c2f5, data reload: false
------ Round 1 ----------------------------------
q1 18174 4427 4338 4338
q2 2323 206 202 202
q3 11363 1121 1018 1018
q4 10483 813 855 813
q5 7896 2774 2584 2584
q6 226 141 140 140
q7 965 621 623 621
q8 9529 2106 2065 2065
q9 9020 6484 6498 6484
q10 8930 3749 3676 3676
q11 464 242 244 242
q12 399 225 227 225
q13 17760 2995 2991 2991
q14 255 216 227 216
q15 518 470 468 468
q16 512 372 373 372
q17 956 704 708 704
q18 8111 7452 7305 7305
q19 8138 1448 1423 1423
q20 657 312 333 312
q21 4946 3166 3192 3166
q22 396 334 335 334
Total cold run time: 122021 ms
Total hot run time: 39699 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4353 4214 4487 4214
q2 381 258 270 258
q3 2966 2741 2750 2741
q4 1865 1599 1589 1589
q5 5217 5261 5236 5236
q6 220 126 132 126
q7 2107 1757 1762 1757
q8 3137 3313 3337 3313
q9 8319 8355 8392 8355
q10 3891 3724 3696 3696
q11 583 480 490 480
q12 785 606 586 586
q13 17540 2992 2986 2986
q14 288 250 264 250
q15 531 468 468 468
q16 459 406 443 406
q17 1741 1471 1465 1465
q18 7612 7518 7369 7369
q19 1669 1559 1597 1559
q20 1959 1771 1788 1771
q21 4725 4691 4695 4691
q22 614 535 555 535
Total cold run time: 70962 ms
Total hot run time: 53851 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165921244
TeamCity be ut coverage result:
Function Coverage: 36.45% (8988/24660)
Line Coverage: 28.02% (73666/262909)
Region Coverage: 27.50% (38268/139178)
Branch Coverage: 24.20% (19509/80620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e5f493df0bfffb57bea05e144dbc79b37e57c2f5_e5f493df0bfffb57bea05e144dbc79b37e57c2f5/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165867469
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2167314495
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165701931
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon merged PR #36277:
URL: https://github.com/apache/doris/pull/36277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165797420
<details>
<summary>TPC-DS: <b>Total hot run time: 171890 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7589480981ef8928ce877a19625abf106759cf47, data reload: false
query1 925 374 376 374
query2 6469 2496 2362 2362
query3 6644 205 215 205
query4 19536 17353 17337 17337
query5 4182 467 446 446
query6 252 163 163 163
query7 4604 291 293 291
query8 335 301 316 301
query9 8673 2459 2424 2424
query10 618 311 307 307
query11 10525 9926 9989 9926
query12 139 87 85 85
query13 1657 362 365 362
query14 10168 7551 6313 6313
query15 241 196 194 194
query16 8098 270 263 263
query17 1925 534 532 532
query18 2094 277 269 269
query19 199 158 151 151
query20 91 85 80 80
query21 214 131 128 128
query22 4257 4092 4022 4022
query23 33533 32985 33089 32985
query24 11048 2827 2812 2812
query25 621 351 360 351
query26 1570 152 156 152
query27 3001 314 328 314
query28 7531 2049 2059 2049
query29 960 622 612 612
query30 260 151 151 151
query31 932 724 740 724
query32 98 56 55 55
query33 772 282 288 282
query34 956 472 466 466
query35 754 666 593 593
query36 1108 935 941 935
query37 172 74 71 71
query38 2904 2751 2754 2751
query39 846 814 795 795
query40 285 129 126 126
query41 55 50 53 50
query42 118 102 99 99
query43 605 543 571 543
query44 1226 714 720 714
query45 202 169 161 161
query46 1080 731 710 710
query47 1858 1787 1762 1762
query48 376 302 288 288
query49 1171 410 399 399
query50 751 388 379 379
query51 6790 6709 6644 6644
query52 106 97 95 95
query53 359 296 283 283
query54 957 440 442 440
query55 76 71 79 71
query56 282 309 262 262
query57 1154 1042 1045 1042
query58 248 232 239 232
query59 3397 3120 3070 3070
query60 296 267 273 267
query61 95 92 89 89
query62 656 442 444 442
query63 324 294 290 290
query64 9909 2305 1699 1699
query65 3143 3144 3101 3101
query66 1348 342 329 329
query67 15502 15008 14961 14961
query68 4558 532 530 530
query69 465 301 307 301
query70 1204 1069 1146 1069
query71 389 277 271 271
query72 7367 5471 5531 5471
query73 737 329 335 329
query74 5969 5530 5466 5466
query75 3389 2659 2683 2659
query76 2523 979 877 877
query77 427 299 313 299
query78 10302 9694 9889 9694
query79 2667 505 505 505
query80 1939 468 463 463
query81 571 221 216 216
query82 781 106 106 106
query83 301 178 168 168
query84 264 87 87 87
query85 1980 280 267 267
query86 506 314 330 314
query87 3263 3090 3114 3090
query88 4046 2456 2435 2435
query89 470 377 385 377
query90 1782 196 198 196
query91 132 100 101 100
query92 67 49 50 49
query93 1966 505 491 491
query94 1233 201 196 196
query95 422 323 321 321
query96 590 274 276 274
query97 3185 3052 3078 3052
query98 234 201 197 197
query99 1271 853 839 839
Total cold run time: 276281 ms
Total hot run time: 171890 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165812143
<details>
<summary>ClickBench: <b>Total hot run time: 30.32 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7589480981ef8928ce877a19625abf106759cf47, data reload: false
query1 0.04 0.03 0.04
query2 0.08 0.03 0.04
query3 0.23 0.05 0.04
query4 1.69 0.07 0.07
query5 0.50 0.49 0.47
query6 1.13 0.72 0.72
query7 0.02 0.01 0.02
query8 0.05 0.04 0.04
query9 0.54 0.47 0.50
query10 0.55 0.54 0.55
query11 0.15 0.11 0.11
query12 0.14 0.12 0.12
query13 0.59 0.59 0.60
query14 0.77 0.80 0.78
query15 0.84 0.81 0.80
query16 0.36 0.35 0.38
query17 0.94 1.01 0.97
query18 0.20 0.27 0.22
query19 1.80 1.82 1.76
query20 0.02 0.01 0.01
query21 15.43 0.65 0.65
query22 4.69 7.14 1.78
query23 18.25 1.34 1.32
query24 2.14 0.23 0.21
query25 0.16 0.08 0.09
query26 0.25 0.17 0.17
query27 0.07 0.08 0.08
query28 13.22 1.02 0.99
query29 12.59 3.26 3.19
query30 0.26 0.06 0.05
query31 2.88 0.38 0.38
query32 3.27 0.47 0.47
query33 2.88 2.90 2.90
query34 16.95 4.42 4.37
query35 4.49 4.57 4.47
query36 0.64 0.47 0.49
query37 0.19 0.15 0.15
query38 0.15 0.15 0.15
query39 0.05 0.04 0.04
query40 0.20 0.15 0.14
query41 0.10 0.04 0.04
query42 0.05 0.04 0.05
query43 0.05 0.05 0.05
Total cold run time: 109.6 s
Total hot run time: 30.32 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2167465176
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165767809
<details>
<summary>TPC-H: <b>Total hot run time: 39519 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7589480981ef8928ce877a19625abf106759cf47, data reload: false
------ Round 1 ----------------------------------
q1 17684 4461 4260 4260
q2 2035 209 196 196
q3 10507 1151 1112 1112
q4 10237 698 802 698
q5 7504 2773 2689 2689
q6 226 142 135 135
q7 977 627 600 600
q8 9395 2100 2112 2100
q9 9172 6452 6459 6452
q10 8852 3732 3734 3732
q11 442 239 235 235
q12 472 233 220 220
q13 17763 2968 2962 2962
q14 263 218 219 218
q15 507 458 467 458
q16 519 372 372 372
q17 953 631 727 631
q18 7917 7384 7266 7266
q19 4616 1394 1412 1394
q20 657 308 320 308
q21 4948 3231 3152 3152
q22 386 344 329 329
Total cold run time: 116032 ms
Total hot run time: 39519 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4355 4209 4227 4209
q2 367 264 256 256
q3 2970 2727 2732 2727
q4 1841 1587 1604 1587
q5 5247 5270 5250 5250
q6 212 126 130 126
q7 2134 1735 1738 1735
q8 3167 3320 3324 3320
q9 8401 8404 8350 8350
q10 3856 3625 3630 3625
q11 583 500 490 490
q12 768 613 569 569
q13 17478 2980 2992 2980
q14 292 262 257 257
q15 521 478 473 473
q16 483 404 423 404
q17 1785 1478 1459 1459
q18 7647 7558 7325 7325
q19 4094 1667 1526 1526
q20 1993 1778 1757 1757
q21 4880 4729 4724 4724
q22 612 539 525 525
Total cold run time: 73686 ms
Total hot run time: 53674 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165950273
<details>
<summary>TPC-DS: <b>Total hot run time: 171755 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e5f493df0bfffb57bea05e144dbc79b37e57c2f5, data reload: false
query1 939 384 372 372
query2 6462 2346 2130 2130
query3 6660 205 208 205
query4 18813 17288 17310 17288
query5 4155 466 458 458
query6 265 156 157 156
query7 4587 308 292 292
query8 327 288 292 288
query9 8524 2434 2399 2399
query10 598 296 282 282
query11 10808 10074 10066 10066
query12 135 83 85 83
query13 1633 362 372 362
query14 9451 7672 6466 6466
query15 229 197 195 195
query16 7993 276 269 269
query17 1896 566 517 517
query18 2024 269 264 264
query19 198 165 150 150
query20 91 86 83 83
query21 206 123 123 123
query22 4303 3957 3948 3948
query23 33678 32967 33153 32967
query24 10943 2844 2803 2803
query25 635 360 356 356
query26 1429 154 151 151
query27 3043 321 314 314
query28 7675 2044 2025 2025
query29 927 631 602 602
query30 287 151 150 150
query31 980 727 755 727
query32 96 54 55 54
query33 765 290 296 290
query34 940 478 460 460
query35 749 630 619 619
query36 1101 931 936 931
query37 153 70 67 67
query38 2877 2748 2710 2710
query39 877 794 794 794
query40 212 128 126 126
query41 58 55 56 55
query42 125 100 99 99
query43 584 529 546 529
query44 1280 717 721 717
query45 205 167 168 167
query46 1089 727 729 727
query47 1879 1813 1814 1813
query48 386 293 296 293
query49 1075 399 400 399
query50 759 394 377 377
query51 6828 6687 6644 6644
query52 103 92 91 91
query53 358 285 282 282
query54 863 444 432 432
query55 74 71 72 71
query56 294 288 264 264
query57 1149 1055 1035 1035
query58 243 230 260 230
query59 3436 3086 3221 3086
query60 291 263 269 263
query61 94 92 91 91
query62 653 430 446 430
query63 315 287 298 287
query64 8962 2280 1749 1749
query65 3310 3140 3112 3112
query66 1392 332 350 332
query67 15627 14886 14823 14823
query68 4532 531 523 523
query69 464 309 306 306
query70 1150 1082 1172 1082
query71 389 274 273 273
query72 7224 5790 5293 5293
query73 743 318 321 318
query74 6059 5769 5577 5577
query75 3476 2662 2671 2662
query76 2474 990 953 953
query77 430 288 295 288
query78 10301 9895 9871 9871
query79 2491 522 496 496
query80 1099 460 504 460
query81 584 220 218 218
query82 754 101 105 101
query83 237 166 165 165
query84 242 85 84 84
query85 1467 284 267 267
query86 469 299 319 299
query87 3278 3119 3119 3119
query88 3682 2422 2420 2420
query89 466 376 389 376
query90 1787 192 184 184
query91 127 104 97 97
query92 59 51 60 51
query93 1670 504 492 492
query94 1213 185 185 185
query95 412 308 316 308
query96 585 272 265 265
query97 3217 3046 3035 3035
query98 216 212 201 201
query99 1289 846 849 846
Total cold run time: 271682 ms
Total hot run time: 171755 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "eldenmoon (via GitHub)" <gi...@apache.org>.
eldenmoon commented on code in PR #36277:
URL: https://github.com/apache/doris/pull/36277#discussion_r1639471280
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2692,13 +2715,16 @@ void SegmentIterator::_calculate_pred_in_remaining_conjunct_root(
auto node_type = expr->node_type();
if (node_type == TExprNodeType::SLOT_REF) {
+ auto slot_expr = std::dynamic_pointer_cast<doris::vectorized::VSlotRef>(expr);
Review Comment:
if (node_type == TExprNodeType::SLOT_REF) ， it must be doris::vectorized::VSlotRef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165717070
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Optimization](Variant) Using correct column name to go fast execute … [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36277:
URL: https://github.com/apache/doris/pull/36277#issuecomment-2165750311
TeamCity be ut coverage result:
Function Coverage: 36.44% (8986/24660)
Line Coverage: 28.01% (73637/262906)
Region Coverage: 27.48% (38244/139176)
Branch Coverage: 24.18% (19497/80618)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7589480981ef8928ce877a19625abf106759cf47_7589480981ef8928ce877a19625abf106759cf47/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org