You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/02 12:49:33 UTC
Re: Review Request 66776: Changed failure check for a call to
os::system().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66776/#review202274
-----------------------------------------------------------
Ship it!
LGTM, but could you please create a ticket for fixing the weird semantics of `os::system`?
- Benjamin Bannier
On April 24, 2018, 4:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66776/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 4:40 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous check for `None()` was missing the case where the
> program exited with a non-zero exit status.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/memory_profiler.cpp 5d6e9dc9b6d26c0efd5f2383d5ad36a136861591
>
>
> Diff: https://reviews.apache.org/r/66776/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 66776: Changed failure check for a call to
os::system().
Posted by Benno Evers <be...@mesosphere.com>.
> On May 2, 2018, 12:49 p.m., Benjamin Bannier wrote:
> > LGTM, but could you please create a ticket for fixing the weird semantics of `os::system`?
Opened https://issues.apache.org/jira/browse/MESOS-8869
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66776/#review202274
-----------------------------------------------------------
On April 24, 2018, 2:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66776/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:40 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous check for `None()` was missing the case where the
> program exited with a non-zero exit status.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/memory_profiler.cpp 5d6e9dc9b6d26c0efd5f2383d5ad36a136861591
>
>
> Diff: https://reviews.apache.org/r/66776/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>