You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Gert Vanthienen (JIRA)" <ji...@apache.org> on 2007/04/11 14:40:34 UTC
[jira] Created: (SM-932) Enable PMD/CheckStyle for binding
components
Enable PMD/CheckStyle for binding components
--------------------------------------------
Key: SM-932
URL: https://issues.apache.org/activemq/browse/SM-932
Project: ServiceMix
Issue Type: Task
Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
Reporter: Gert Vanthienen
Priority: Minor
PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated SM-932:
-------------------------------
Attachment: SM-932-ftp.patch
SM-932-ftp.patch fixes PDM/CheckStyle errors for servicemix-ftp
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated SM-932:
-------------------------------
Attachment: SM-932-http-part2.patch
Additional http patch file to provide the missing AbstractProcessor file
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http-part2.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39721 ]
Gert Vanthienen commented on SM-932:
------------------------------------
Fixed for servicemix-ftp
http://svn.apache.org/viewvc?view=rev&revision=557640
Fixed for servicemix-http
http://svn.apache.org/viewvc?view=rev&revision=557757
Fixed for servicemix-jms
http://svn.apache.org/viewvc?view=rev&revision=557769
Fixed for servicemix-truezip
http://svn.apache.org/viewvc?view=rev&revision=557978
Fixed for servicemix-xmpp
http://svn.apache.org/viewvc?view=rev&revision=557981
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http-part2.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated SM-932:
-------------------------------
Attachment: SM-932-jms.patch
SM-932-jms.patch fixes PDM/CheckStyle errors for servicemix-jms
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-jms.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated SM-932:
-------------------------------
Attachment: SM-932-http.patch
The last patch file (*-http) contains all necessary modifications for servicemix-http. It also contains the updated pom.xml for the binding components.
Just a few remarks:
* I have used some J2SE 5.0 constructs (varargs, generics, ...) during the cleanup (e.g. to reduce the amount of code per method). If you still want to be 1.4-compliant, these have to be modified
* SslParameters contains a call to hash(String... strings). If I don't enclose the parameters to this call in a new String[] { }, PMD (incorrectly) complains about an unused private method
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Thomas Termin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39053 ]
Thomas Termin commented on SM-932:
----------------------------------
Fixed for servicemix-http! Thanks a lot to Gert Vanthienen!
Author: tterm
Date: Fri Apr 27 05:23:20 2007
New Revision: 533074
URL: http://svn.apache.org/viewvc?view=rev&rev=533074
Log:
SM-932 Enable PMD/CheckStyle for binding components
Added:
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/AbstractProcessor.java
Removed:
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/Constants.java
Modified:
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/BasicAuthCredentials.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/ContextManager.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpBootstrap.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpBridgeServlet.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpComponent.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpConfiguration.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpConfigurationMBean.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpEndpoint.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpManagedServlet.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpProcessor.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/HttpWsdl1Deployer.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/ManagedContextManager.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/ProxyParameters.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/SslParameters.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/DefaultHttpConsumerMarshaler.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/DefaultHttpProviderMarshaler.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/HttpConsumerEndpoint.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/HttpConsumerMarshaler.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/HttpProviderEndpoint.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/HttpProviderMarshaler.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/HttpSoapConsumerEndpoint.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/HttpSoapConsumerMarshaler.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/endpoints/SerializedMarshaler.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JCLLogger.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JaasJettyPrincipal.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JaasUserRealm.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/JettyContextManager.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/jetty/ServiceMixSslSocketConnector.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/packaging/HttpServiceUnitAnalyzer.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/CommonsHttpSSLSocketFactory.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ConsumerProcessor.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/processors/ProviderProcessor.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/main/java/org/apache/servicemix/http/tools/PortTypeDecorator.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/ConsumerEndpointTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpAddressingTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpConsumerTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpManagedTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpProviderTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpSoapTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpSpringTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpTxTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpURITest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpWsdlTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/HttpXBeanDeployerTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/ServerManagerTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/WsdlRoundtripTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/endpoints/Person.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/endpoints/PersonImpl.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/endpoints/SerializedMarshalerTest.java
incubator/servicemix/trunk/deployables/bindingcomponents/servicemix-http/src/test/java/org/apache/servicemix/http/security/HttpSecurityTest.java
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http-part2.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Thomas Termin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39046 ]
Thomas Termin commented on SM-932:
----------------------------------
Gert,
the http patch doesn't work. There is a class missing: AbstractProcessor. I guess you forgot to add this class to svn before you do the svn diff.
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen resolved SM-932.
--------------------------------
Resolution: Fixed
Fix Version/s: 3.2
Updated the binding components' parent pom.xml
http://svn.apache.org/viewvc?view=rev&revision=557983
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Fix For: 3.2
>
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http-part2.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated SM-932:
-------------------------------
Attachment: SM-932-xmpp.patch
SM-932-truezip.patch
Patches for servicemix-truezip and servicemix-xmpp
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39702 ]
Gert Vanthienen commented on SM-932:
------------------------------------
Fixed for servicemix-file:
http://svn.apache.org/viewvc?view=rev&revision=557551
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch, SM-932-ftp.patch, SM-932-http-part2.patch, SM-932-http.patch, SM-932-jms.patch, SM-932-truezip.patch, SM-932-xmpp.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-932) Enable PMD/CheckStyle for binding
components
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen updated SM-932:
-------------------------------
Attachment: SM-932-file.patch
SM-932-file.patch fixes PDM/CheckStyle errors for servicemix-ftp
> Enable PMD/CheckStyle for binding components
> --------------------------------------------
>
> Key: SM-932
> URL: https://issues.apache.org/activemq/browse/SM-932
> Project: ServiceMix
> Issue Type: Task
> Components: servicemix-file, servicemix-ftp, servicemix-http, servicemix-jms, servicemix-truezip
> Reporter: Gert Vanthienen
> Priority: Minor
> Attachments: SM-932-file.patch
>
>
> PMD/CheckStyle should be enabled for binding components
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.